NO-JIRA: Improve error message in vsphere-plugin #15437
Conversation
celdrake
force-pushed
the
vsphere-configMap-info
branch
from
72c52fb to
ea76515
Compare
|
/retest |
|
/label NO-JIRA: Improve error message in vsphere-plugin |
|
/retitle NO-JIRA: Improve error message in vsphere-plugin |
openshift-ci
bot
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@celdrake: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
| throw new PersistError( | ||
| t('Failed to parse cloud provider config {{cm}}', { cm: cloudProviderConfig.metadata.name }), | ||
| t('Unknown format'), | ||
| t('Failed to parse cloud provider config {{cm}}. ', { |
There was a problem hiding this comment.
the extra space and punctuation in this string is causing duplicate strings to appear in the locales json file
| t('Failed to parse cloud provider config {{cm}}. ', { | |
| t('Failed to parse cloud provider config {{cm}}', { |
There was a problem hiding this comment.
Absolutely right, thanks! I'm fixing it now.
openshift-ci
bot
added
the
tide/merge-method-squash
openshift-ci
bot
added
px-approved
|
@yanpzhan is working on PR verification |
|
@celdrake I'm trying to verify the pr. Could you point me which resource field you modified to trigger the error? Thanks in advance. |
|
@yanpzhan What I did is to create a cluster using ClusterBot with the instruction "launch 4.17 vsphere". Then any modification should trigger the issue. Try modifying the folder for example. |
|
@celdrake This is the warning info when I update 'Virtual Machine Folder * ' field with '/DEVQEdatacenter-2/vm/prtest', seems not the expected info. |
|
@yanpzhan In this case, it seems your vsphere settings are all correct. Therefore no error is displayed when you make any changes to the Vsphere connection details, and they can be successfully updated (which is the happy path). My PR only adds extra information when the vsphere settings have mismatches between different CRDs. Is it possible for you to check with the clusterBot's cluster? |
|
Reproduced the issue on 4.17 cluster, bridge console with the pr code, now there is more detailed failure info. after: |
openshift-ci
bot
added
the
qe-approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: celdrake, logonoff The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/verified by yanpzhan |
openshift-ci-robot
added
the
verified
|
@logonoff: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
1 similar comment
|
@celdrake: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
6 participants
Whenever the "cloud-provider-config" ConfigMap has different data that the UI expects, the edition of the vsphere connection details fails and there's no helpful information about why it failed.
Now, we clearly display what data that we cannot find in the initial ConfigMap is preventing us from making the changes the user requested.