Skip to content

CONSOLE-4727: Update OWNERS files across the repo #15461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
Sep 11, 2025
Merged

CONSOLE-4727: Update OWNERS files across the repo #15461

openshift-merge-bot merged 1 commit into from
Sep 11, 2025

Conversation

@jhadvig
Copy link
Member

@jhadvig jhadvig commented Sep 4, 2025

Acceptance Criteria:

Static plugins:

  • In plugins owned by the Console team, remove the approvers and reviewers sections.
  • Keep only the labels section for ownership tracking.

Helm plugin:

  • Update the OWNERS file with the correct maintainers from the Helm team.

Public folder:

  • Review the OWNERS file under frontend/ and Remove inactive owners who are no longer participating.

/assign @rhamilto

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 4, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 4, 2025 •
edited by openshift-ci bot
Loading

@jhadvig: This pull request references CONSOLE-4727 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

Acceptance Criteria:

Static plugins:

  • In plugins owned by the Console team, remove the approvers and reviewers sections.
  • Keep only the labels section for ownership tracking.

Helm plugin:

  • Update the OWNERS file with the correct maintainers from the Helm team.

Public folder:

  • Review the OWNERS file under frontend/ and Remove inactive owners who are no longer participating.

/assign @rhamilto

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 4, 2025
@openshift-ci openshift-ci bot requested review from baijum and cajieh September 4, 2025 14:13
@openshift-ci openshift-ci bot added component/backend Related to backend component/core Related to console core functionality approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console component/git-service Related to git-service component/gitops Related to gitops-plugin component/helm Related to helm-plugin component/knative Related to knative-plugin component/olm Related to OLM component/pipelines Related to pipelines-plugin component/sdk Related to console-plugin-sdk component/topology Related to topology kind/cypress Related to Cypress e2e integration testing kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels Sep 4, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 4, 2025
@rhamilto
Copy link
Member

rhamilto commented Sep 4, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 4, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@christoph-jerolimov
Copy link
Member

christoph-jerolimov commented Sep 4, 2025

We had a good time. Salute 🫡

/woof

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 4, 2025

@christoph-jerolimov: dog image

Details

In response to this:

We had a good time. Salute 🫡

/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jhadvig jhadvig added docs-approved Signifies that Docs has signed off on this PR qe-approved Signifies that QE has signed off on this PR labels Sep 8, 2025
@jhadvig jhadvig added the px-approved Signifies that Product Support has signed off on this PR label Sep 8, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 8, 2025 •
edited by openshift-ci bot
Loading

@jhadvig: This pull request references CONSOLE-4727 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

Acceptance Criteria:

Static plugins:

  • In plugins owned by the Console team, remove the approvers and reviewers sections.
  • Keep only the labels section for ownership tracking.

Helm plugin:

  • Update the OWNERS file with the correct maintainers from the Helm team.

Public folder:

  • Review the OWNERS file under frontend/ and Remove inactive owners who are no longer participating.

/assign @rhamilto

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jhadvig jhadvig added the plugin-api-approved Indicates a PR with plugin API changes has been approved by an API reviewer label Sep 8, 2025
@jhadvig
Copy link
Member Author

jhadvig commented Sep 11, 2025

/verified by @jhadvig

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 11, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 11, 2025

@jhadvig: This PR has been marked as verified by @jhadvig.

Details

In response to this:

/verified by @jhadvig

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 11, 2025

@jhadvig: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 634d01e into openshift:main Sep 11, 2025
3 checks passed
logonoff added a commit to logonoff/release that referenced this pull request Nov 21, 2025
@logonoff
fix: add kind/demo-plugin label
f5e3eb8 
Related PR: openshift/console#15461
@logonoff logonoff mentioned this pull request Nov 21, 2025
Merged
logonoff added a commit to logonoff/release that referenced this pull request Nov 25, 2025
@logonoff
fix: add kind/demo-plugin label
aa4ba65 
Related PR: openshift/console#15461
openshift-merge-bot bot pushed a commit to openshift/release that referenced this pull request Dec 15, 2025
@logonoff
OCPBUGS-65887: add kind/demo-plugin label and bump console-plugin-tem…
ee0b1df 
…plate to node 22 (#71710)

* fix: add `kind/demo-plugin` label

Related PR: openshift/console#15461

* fix: bump console-plugin-template to node 18

* fix: bump console-plugin-template to node 22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@baijum baijum Awaiting requested review from baijum

@cajieh cajieh Awaiting requested review from cajieh

Assignees

@rhamilto rhamilto

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/backend Related to backend component/core Related to console core functionality component/dev-console Related to dev-console component/git-service Related to git-service component/gitops Related to gitops-plugin component/helm Related to helm-plugin component/knative Related to knative-plugin component/olm Related to OLM component/pipelines Related to pipelines-plugin component/sdk Related to console-plugin-sdk component/topology Related to topology docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/cypress Related to Cypress e2e integration testing kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged. plugin-api-approved Indicates a PR with plugin API changes has been approved by an API reviewer px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jhadvig @openshift-ci-robot @rhamilto @christoph-jerolimov @openshift-merge-robot