Skip to content

Conversation

@TheRealJon
Copy link
Member

  • Add --tech-preview command line flag to enable tech preview features
  • Include TechPreviewEnabled field in ClusterInfo configuration
  • Log warning when tech preview features are enabled

🤖 Generated with Claude Code

- Add --tech-preview command line flag to enable tech preview features
- Include TechPreviewEnabled field in ClusterInfo configuration
- Log warning when tech preview features are enabled

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 9, 2025

@TheRealJon: This pull request references CONSOLE-4764 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

  • Add --tech-preview command line flag to enable tech preview features
  • Include TechPreviewEnabled field in ClusterInfo configuration
  • Log warning when tech preview features are enabled

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 9, 2025
@openshift-ci openshift-ci bot requested review from jhadvig and spadgett September 9, 2025 20:51
@openshift-ci openshift-ci bot added component/backend Related to backend approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 9, 2025
@TheRealJon
Copy link
Member Author

/hold

Test with openshift/console-operator#1043

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 9, 2025
@TheRealJon
Copy link
Member Author

/retest

@TheRealJon
Copy link
Member Author

/retest

{  test "frontend" failed: could not watch pod: context canceled }

@TheRealJon
Copy link
Member Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 11, 2025
@Leo6Leo
Copy link
Contributor

Leo6Leo commented Sep 11, 2025

/lgtm

All the changes look reasonable to me, therefore adding the lgtm label. Thanks @TheRealJon !

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 11, 2025
@TheRealJon
Copy link
Member Author

/retest

{  test "frontend" failed: could not watch pod: context canceled}

@TheRealJon
Copy link
Member Author

QE Approver
/assign @yapei

Docs Approver:
/assign @jseseCCS

PX Approver:
/assign @sferich888

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 12, 2025

@TheRealJon: GitHub didn't allow me to assign the following users: jseseCCS.

Note that only openshift members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

Details

In response to this:

QE Approver
/assign @yapei

Docs Approver:
/assign @jseseCCS

PX Approver:
/assign @sferich888

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@yapei
Copy link
Contributor

yapei commented Sep 15, 2025

tested together with openshift/console-operator#1043, no issues found

$ ./bin/bridge -tech-preview=false
W0915 15:36:38.908195   42095 authoptions.go:112] Flag inactivity-timeout is set to less then 300 seconds and will be ignored!
W0915 15:36:38.908354   42095 authoptions.go:265] running with AUTHENTICATION DISABLED -- for development use only!
I0915 15:36:38.909776   42095 main.go:723] Binding to 0.0.0.0:9000...
I0915 15:36:38.909782   42095 main.go:725] Not using TLS
I0915 15:36:41.910845   42095 metrics.go:133] serverconfig.Metrics: Update ConsolePlugin metrics...
..............................

$ ./bin/bridge -tech-preview=true
W0915 15:36:53.575962   42137 main.go:183] Tech preview features are enabled
W0915 15:36:53.575978   42137 authoptions.go:112] Flag inactivity-timeout is set to less then 300 seconds and will be ignored!
W0915 15:36:53.576116   42137 authoptions.go:265] running with AUTHENTICATION DISABLED -- for development use only!
I0915 15:36:53.577740   42137 main.go:723] Binding to 0.0.0.0:9000...
I0915 15:36:53.577743   42137 main.go:725] Not using TLS

/verified by @yapei
/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Sep 15, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 15, 2025

@TheRealJon: This pull request references CONSOLE-4764 which is a valid jira issue.

Details

In response to this:

  • Add --tech-preview command line flag to enable tech preview features
  • Include TechPreviewEnabled field in ClusterInfo configuration
  • Log warning when tech preview features are enabled

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 15, 2025
@openshift-ci-robot
Copy link
Contributor

@yapei: This PR has been marked as verified by @yapei.

Details

In response to this:

tested together with openshift/console-operator#1043, no issues found

$ ./bin/bridge -tech-preview=false
W0915 15:36:38.908195   42095 authoptions.go:112] Flag inactivity-timeout is set to less then 300 seconds and will be ignored!
W0915 15:36:38.908354   42095 authoptions.go:265] running with AUTHENTICATION DISABLED -- for development use only!
I0915 15:36:38.909776   42095 main.go:723] Binding to 0.0.0.0:9000...
I0915 15:36:38.909782   42095 main.go:725] Not using TLS
I0915 15:36:41.910845   42095 metrics.go:133] serverconfig.Metrics: Update ConsolePlugin metrics...
..............................

$ ./bin/bridge -tech-preview=true
W0915 15:36:53.575962   42137 main.go:183] Tech preview features are enabled
W0915 15:36:53.575978   42137 authoptions.go:112] Flag inactivity-timeout is set to less then 300 seconds and will be ignored!
W0915 15:36:53.576116   42137 authoptions.go:265] running with AUTHENTICATION DISABLED -- for development use only!
I0915 15:36:53.577740   42137 main.go:723] Binding to 0.0.0.0:9000...
I0915 15:36:53.577743   42137 main.go:725] Not using TLS

/verified by @yapei
/label qe-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sferich888
Copy link

/label px-approved

@openshift-ci openshift-ci bot added the px-approved Signifies that Product Support has signed off on this PR label Sep 16, 2025
Copy link

@jseseCCS jseseCCS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheRealJon what do you say?

@openshift-ci-robot openshift-ci-robot removed the verified Signifies that the PR passed pre-merge verification criteria label Sep 17, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2025
@TheRealJon
Copy link
Member Author

@yapei @Leo6Leo Do you mind taking another look after the recent feedback changes?

@Leo6Leo
Copy link
Contributor

Leo6Leo commented Sep 17, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2025
@Leo6Leo
Copy link
Contributor

Leo6Leo commented Sep 17, 2025

/retest-required

@yapei
Copy link
Contributor

yapei commented Sep 18, 2025

$ oc patch  featuregate cluster -p '{"spec": {"featureSet": "TechPreviewNoUpgrade"}}' --type merge
featuregate.config.openshift.io/cluster patched
$ oc get cm console-config -n openshift-console -o yaml | grep clusterInfo -A10
    clusterInfo:
      consoleBaseAddress: https://console-openshift-console.apps.ci-ln-h9qi0rb-76ef8.aws-2.ci.openshift.org
      controlPlaneTopology: HighlyAvailable
      masterPublicURL: https://api.ci-ln-h9qi0rb-76ef8.aws-2.ci.openshift.org:6443
      nodeArchitectures:
      - amd64
      nodeOperatingSystems:
      - linux
      releaseVersion: 4.21.0-0-2025-09-18-021036-test-ci-ln-h9qi0rb-latest
      techPreviewEnabled: true
    contentSecurityPolicyEnabled: true
$ oc logs console-6755cd4bc5-572jk -n openshift-console
W0918 03:17:33.324010       1 main.go:183] Technology Preview features are enabled. These features are experimental and not supported for production use. If you encounter issues, send feedback through the usual support or bug-reporting channels.
I0918 03:17:33.324044       1 main.go:264] Console plugins are enabled in following order:
......................................................
$  oc logs console-operator-75486874fb-qfbbl  -n openshift-console-operator | grep -i "tech.*preview"
I0918 03:17:04.516651       1 sync_v400.go:575] Console Technology Preview features enabled based on cluster FeatureSet TechPreviewNoUpgrade.
I0918 03:17:05.442203       1 sync_v400.go:575] Console Technology Preview features enabled based on cluster FeatureSet TechPreviewNoUpgrade.
I0918 03:17:06.444818       1 sync_v400.go:575] Console Technology Preview features enabled based on cluster FeatureSet TechPreviewNoUpgrade.
....................................

the new changes look good

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2025
@Leo6Leo
Copy link
Contributor

Leo6Leo commented Sep 18, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2025
Copy link

@jseseCCS jseseCCS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! /label docs-approved

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jseseCCS, Leo6Leo, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Leo6Leo
Copy link
Contributor

Leo6Leo commented Sep 18, 2025

lgtm! /label docs-approved

/label docs-approved

@jseseCCS Just a tip: the commands need to be in the new line, otherwise the bot won't recognize it.

@openshift-ci openshift-ci bot added the docs-approved Signifies that Docs has signed off on this PR label Sep 18, 2025
@TheRealJon
Copy link
Member Author

Thanks @Leo6Leo!

@TheRealJon
Copy link
Member Author

the new changes look good

/verified by @yapei

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Sep 19, 2025
@openshift-ci-robot
Copy link
Contributor

@TheRealJon: This PR has been marked as verified by @yapei.

Details

In response to this:

the new changes look good

/verified by @yapei

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 68f6c11 and 2 for PR HEAD d116a47 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 11d1f43 and 1 for PR HEAD d116a47 in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 20, 2025

@TheRealJon: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 6494105 into openshift:main Sep 20, 2025
8 checks passed
@TheRealJon TheRealJon deleted the CONSOLE-4764 branch September 22, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/backend Related to backend docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants