Skip to content

[release-4.20] OCPBUGS-61330: fix namespace path generation for non-namespaced resources #15498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
Nov 16, 2025
Merged

[release-4.20] OCPBUGS-61330: fix namespace path generation for non-namespaced resources #15498

openshift-merge-bot merged 1 commit into from
Nov 16, 2025

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Sep 15, 2025

This is an automated cherry-pick of #15467

/assign openshift-ci-robot

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 15, 2025
Merged
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 15, 2025

@openshift-cherrypick-robot: Detected clone of Jira Issue OCPBUGS-58118 with correct target version. Will retitle the PR to link to the clone.
/retitle [release-4.20] OCPBUGS-61330: fix namespace path generation for non-namespaced resources

Details

In response to this:

This is an automated cherry-pick of #15467

/assign openshift-ci-robot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.20] OCPBUGS-58118: fix namespace path generation for non-namespaced resources [release-4.20] OCPBUGS-61330: fix namespace path generation for non-namespaced resources Sep 15, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Sep 15, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 15, 2025

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-61330, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-58118 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-58118 targets the "4.21.0" version, which is one of the valid target versions: 4.21.0
  • bug has dependents

Requesting review from QA contact:
/cc @yapei

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #15467

/assign openshift-ci-robot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the component/sdk Related to console-plugin-sdk label Sep 15, 2025
@TheRealJon @claude
OCPBUGS-58118: fix namespace path generation for non-namespaced resou…
a9373cc 
…rces

Only add namespace path segment when the resource model is actually namespaced.
This prevents incorrect API paths for cluster-scoped resources.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@openshift-cherrypick-robot openshift-cherrypick-robot force-pushed the cherry-pick-15467-to-release-4.20 branch from 6c9f917 to a9373cc Compare September 16, 2025 13:30
@yanpzhan
Copy link
Contributor

yanpzhan commented Oct 29, 2025

On cluster launched against the pr, created kueue csv and kueue crd with files from https://github.com/openshift/kueue-operator/tree/main/bundle/manifests, then went to installed operators page. Created kueue instance with form view, there is not error now.
/label qe-approved
/verified by @yanpzhan

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Oct 29, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 29, 2025

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-61330, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.z) matches configured target version for branch (4.20.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-58118 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-58118 targets the "4.21.0" version, which is one of the valid target versions: 4.21.0
  • bug has dependents

Requesting review from QA contact:
/cc @yanpzhan

Details

In response to this:

This is an automated cherry-pick of #15467

/assign openshift-ci-robot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Oct 29, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 29, 2025

@yanpzhan: This PR has been marked as verified by @yanpzhan.

Details

In response to this:

On cluster launched against the pr, created kueue csv and kueue crd with files from https://github.com/openshift/kueue-operator/tree/main/bundle/manifests, then went to installed operators page. Created kueue instance with form view, there is not error now.
/label qe-approved
/verified by @yanpzhan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from yanpzhan October 29, 2025 04:01
logonoff
logonoff approved these changes Nov 16, 2025
View reviewed changes
Copy link
Member

@logonoff logonoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Nov 16, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 16, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 16, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 16, 2025

/retest-required

Remaining retests: 0 against base HEAD 011bd20 and 2 for PR HEAD a9373cc in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 16, 2025

/retest-required

Remaining retests: 0 against base HEAD 29da336 and 1 for PR HEAD a9373cc in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 16, 2025

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit c179563 into openshift:release-4.20 Nov 16, 2025
7 checks passed
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 16, 2025

@openshift-cherrypick-robot: Jira Issue Verification Checks: Jira Issue OCPBUGS-61330
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-61330 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

This is an automated cherry-pick of #15467

/assign openshift-ci-robot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yapei yapei Awaiting requested review from yapei

@spadgett spadgett Awaiting requested review from spadgett

@vojtechszocs vojtechszocs Awaiting requested review from vojtechszocs

@yanpzhan yanpzhan Awaiting requested review from yanpzhan

1 more reviewer

@logonoff logonoff logonoff approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@yanpzhan yanpzhan

@sanketpathak sanketpathak

@yapei yapei

@logonoff logonoff

@openshift-ci-robot openshift-ci-robot

@XiyunZhao XiyunZhao

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. component/sdk Related to console-plugin-sdk jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@openshift-cherrypick-robot @openshift-ci-robot @yanpzhan @logonoff @sanketpathak @yapei @XiyunZhao @TheRealJon