Skip to content

[release-4.20] OCPBUGS-61785: Add validation and type guards on healthHandler calls to prevent errors #15500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
Nov 28, 2025
Merged

[release-4.20] OCPBUGS-61785: Add validation and type guards on healthHandler calls to prevent errors #15500

openshift-merge-bot merged 1 commit into from
Nov 28, 2025

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Sep 16, 2025

This is an automated cherry-pick of #15470

/assign Mylanos

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 16, 2025
Merged
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 16, 2025

@openshift-cherrypick-robot: Jira Issue OCPBUGS-59972 has been cloned as Jira Issue OCPBUGS-61785. Will retitle bug to link to clone.
/retitle [release-4.20] OCPBUGS-61785: Add validation and type guards on healthHandler calls to prevent errors

Details

In response to this:

This is an automated cherry-pick of #15470

/assign Mylanos

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.20] OCPBUGS-59972: Add validation and type guards on healthHandler calls to prevent errors [release-4.20] OCPBUGS-61785: Add validation and type guards on healthHandler calls to prevent errors Sep 16, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 16, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 16, 2025

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-61785, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #15470

/assign Mylanos

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from rawagner and spadgett September 16, 2025 13:48
@openshift-ci openshift-ci bot added component/core Related to console core functionality component/dashboard Related to dashboard labels Sep 16, 2025
@Mylanos
Copy link
Contributor

Mylanos commented Sep 17, 2025

/retest

6 similar comments
@Mylanos
Copy link
Contributor

Mylanos commented Sep 17, 2025

/retest

@Mylanos
Copy link
Contributor

Mylanos commented Sep 18, 2025

/retest

@Mylanos
Copy link
Contributor

Mylanos commented Sep 19, 2025

/retest

@Mylanos
Copy link
Contributor

Mylanos commented Sep 22, 2025

/retest

@Mylanos
Copy link
Contributor

Mylanos commented Sep 23, 2025

/retest

@Mylanos
Copy link
Contributor

Mylanos commented Sep 25, 2025

/retest

@cajieh
Copy link
Contributor

cajieh commented Sep 25, 2025

/lgtm
/label backport-risk-assessed
/verified later @yapei

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Sep 25, 2025
@openshift-ci-robot openshift-ci-robot added verified-later verified Signifies that the PR passed pre-merge verification criteria labels Sep 25, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 25, 2025

@cajieh: This PR has been marked to be verified later by @yapei.

Details

In response to this:

/lgtm
/label backport-risk-assessed
/verified later @yapei

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Sep 26, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 26, 2025

@Mylanos: This pull request references Jira Issue OCPBUGS-61785, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-59972 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-59972 targets the "4.21.0" version, which is one of the valid target versions: 4.21.0
  • bug has dependents

Requesting review from QA contact:
/cc @yapei

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from yapei September 26, 2025 11:37
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 26, 2025

/retest-required

Remaining retests: 0 against base HEAD 8c75a91 and 2 for PR HEAD 1e66773 in total

@Mylanos
Copy link
Contributor

Mylanos commented Sep 29, 2025

/retest

@Mylanos
Copy link
Contributor

Mylanos commented Sep 29, 2025

/test frontend

@Mylanos
Copy link
Contributor

Mylanos commented Sep 29, 2025

/retest

1 similar comment
@Mylanos
Copy link
Contributor

Mylanos commented Sep 30, 2025

/retest

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 30, 2025

/retest-required

Remaining retests: 0 against base HEAD 8399321 and 1 for PR HEAD 1e66773 in total

@Mylanos
Copy link
Contributor

Mylanos commented Oct 1, 2025

/retest

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 2, 2025

/retest-required

Remaining retests: 0 against base HEAD 0261ebc and 0 for PR HEAD 1e66773 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 3, 2025

/hold

Revision 1e66773 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 3, 2025
@sdodson
Copy link
Member

sdodson commented Oct 15, 2025

/skip

@sdodson
Copy link
Member

sdodson commented Oct 15, 2025

/label staff-eng-approved

@openshift-ci openshift-ci bot added the staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). label Oct 15, 2025
@sdodson
Copy link
Member

sdodson commented Oct 16, 2025

/retest-required

@sdodson
Copy link
Member

sdodson commented Oct 16, 2025

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 16, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 16, 2025

/retest-required

Remaining retests: 0 against base HEAD c26aad4 and 2 for PR HEAD 1e66773 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 24, 2025

/retest-required

Remaining retests: 0 against base HEAD 9364c0e and 1 for PR HEAD 1e66773 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 24, 2025

/retest-required

Remaining retests: 0 against base HEAD 425e760 and 0 for PR HEAD 1e66773 in total

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 24, 2025

/hold

Revision 1e66773 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 24, 2025
@vikram-raj
Copy link
Member

vikram-raj commented Nov 28, 2025

/unhold

/retest

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 28, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 28, 2025

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 71efa9b into openshift:release-4.20 Nov 28, 2025
7 checks passed
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 28, 2025

@openshift-cherrypick-robot: Jira Issue OCPBUGS-61785: All pull requests linked via external trackers have merged:

This pull request has the verified-later tag and will need to be manually moved to VERIFIED after testing. Jira Issue OCPBUGS-61785 has been moved to the MODIFIED state.

Details

In response to this:

This is an automated cherry-pick of #15470

/assign Mylanos

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Nov 29, 2025

Fix included in accepted release 4.20.0-0.nightly-2025-11-29-002756

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rawagner rawagner Awaiting requested review from rawagner

@spadgett spadgett Awaiting requested review from spadgett

@yapei yapei Awaiting requested review from yapei

Assignees

@yanpzhan yanpzhan

@sanketpathak sanketpathak

@yapei yapei

@cajieh cajieh

@Mylanos Mylanos

@XiyunZhao XiyunZhao

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. component/core Related to console core functionality component/dashboard Related to dashboard jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). verified Signifies that the PR passed pre-merge verification criteria verified-later

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.