CONSOLE-4837: Migrate console-app to dynamic

[logonoff]

Note: the cycles produced by the frontend test are NOT as a result of new code introduced in this PR.

When we check for import cycles in the frontend test, we exclude any cycle with get-active-plugins.js. This is because there were a lot of cycles that were very difficult to fix due to the structure of how the console PluginStore is loaded.
Thus, any import cycle which includes the active plugins module doesn't count as a cycle in our eyes.

Meanwhile, each plugin entry point plugin.tsx is imported by the code produced by get-active-plugins.js. Now that we are trying to remove plugin.tsx from console-app, we are uncovering a bunch of import cycles that were previously not counted as get-active-plugins.js was previously in the cycle. Now that the cycles no longer include get-active-plugins, we are counting them.

Reverting only the changes to plugin.tsx shows this -- the detected cycles no longer appear.

Due to the amount of cycles that have to be dealt with (over 200), I want to address this in future work.

[openshift-ci-robot]

@logonoff: This pull request references CONSOLE-4837 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[logonoff]

/label px-approved
/label docs-approved

[logonoff]

/hold

I am stopped by my own tests...

[logonoff]

/unhold

[logonoff]

/retest

[openshift-ci-robot]

@logonoff: This pull request references CONSOLE-4837 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

Note: the cycles produced by the frontend test are NOT as a result of new code introduced in this PR.

When we check for import cycles in the frontend test, we exclude any cycle with get-active-plugins.js. This is because there were a lot of cycles that were very difficult to fix due to the structure of how the console PluginStore is loaded.
Thus, any import cycle which includes the active plugins module doesn't count as a cycle in our eyes.

Meanwhile, each plugin entry point plugin.tsx is imported by the code produced by get-active-plugins.js. Now that we are trying to remove plugin.tsx from console-app, we are uncovering a bunch of import cycles that were previously not counted as get-active-plugins.js was previously in the cycle. Now that the cycles no longer include get-active-plugins, we are counting them.

Reverting only the changes to plugin.tsx shows this -- the detected cycles no longer appear.

Due to the amount of cycles that have to be dealt with (over 200), I want to address this in future work.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[logonoff]

/assign @yapei @vojtechszocs

[XiyunZhao]

/verified by @XiyunZhao
no issue found on the regression testing, and the checkpoint below has been checked

• The labels on the resource list page are displayed correctly
• The title on the resource details page is displayed correctly
• Abbreviations work properly in search and filter functions
• The breadcrumb navigation is displayed correctly
• No console errors or warnings are present
• No errors occur during the build process
• No API error found on the browser console

[openshift-ci-robot]

@XiyunZhao: This PR has been marked as verified by @XiyunZhao.

Details

In response to this:

/verified by @XiyunZhao
no issue found on the regression testing, and the checkpoint below has been checked

• The labels on the resource list page are displayed correctly
• The title on the resource details page is displayed correctly
• Abbreviations work properly in search and filter functions
• The breadcrumb navigation is displayed correctly
• No console errors or warnings are present
• No errors occur during the build process
• No API error found on the browser console

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[vojtechszocs]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: logonoff, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• frontend/OWNERS [logonoff,vojtechszocs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@logonoff: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.