Skip to content

CONSOLE-4840: Remove FeatureFlag/Model and ModelDefinition #15671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 4 commits into from
Nov 7, 2025
Merged

CONSOLE-4840: Remove FeatureFlag/Model and ModelDefinition #15671

openshift-merge-bot merged 4 commits into from
Nov 7, 2025

Conversation

@logonoff
Copy link
Member

@logonoff logonoff commented Nov 4, 2025 •
edited
Loading

All ModelDefinition and FeatureFlag/Model extensions have been removed, so we can also remove their handling.

Fixes #15653 (comment)

API change:

  • ModelDefinition static extension type no longer exported to dynamic plugin SDK
  • Exported dynamic plugin SDK function setPluginStore no longer does anything -- will remove in 4.22. Decided to keep it as a stub function for now to avoid a breaking change

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 4, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 4, 2025 •
edited by openshift-ci bot
Loading

@logonoff: This pull request references CONSOLE-4840 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from Leo6Leo and spadgett November 4, 2025 13:31
@openshift-ci openshift-ci bot added component/core Related to console core functionality component/sdk Related to console-plugin-sdk approved Indicates a PR has been approved by an approver from all required OWNERS files. plugin-api-changed Categorizes a PR as containing plugin API changes labels Nov 4, 2025
@logonoff logonoff force-pushed the CONSOLE-4840-s2e11-booze-cruise branch from 53fa3ac to 99ffdd1 Compare November 4, 2025 13:31
logonoff
logonoff commented Nov 4, 2025
View reviewed changes
frontend/packages/console-dynamic-plugin-sdk/src/api/common-types.ts
Comment on lines -225 to -237
export type AlwaysOnExtension<P extends {} = any> = Omit<Extension<P>, 'flags'>;

namespace ExtensionProperties {
export interface ModelDefinition {
/** Additional Kubernetes model definitions to register with Console. */
models: K8sModel[];
}
}

export interface ModelDefinition extends AlwaysOnExtension<ExtensionProperties.ModelDefinition> {
type: 'ModelDefinition';
}

Copy link
Member Author

@logonoff logonoff Nov 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There really is no reason that any plugin would be using these types as this refers to an extension point in the old system

@logonoff logonoff force-pushed the CONSOLE-4840-s2e11-booze-cruise branch 2 times, most recently from b6bc93d to 71cfdd8 Compare November 5, 2025 03:43
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 6, 2025 •
edited by openshift-ci bot
Loading

@logonoff: This pull request references CONSOLE-4840 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

All ModelDefinition and FeatureFlag/Model extensions have been removed, so we can also remove their handling.

API change:

  • ModelDefinition static extension type no longer exported to dynamic plugin SDK
  • Exported dynamic plugin SDK function setPluginStore no longer does anything -- will remove in 4.22. Decided to keep it as a stub function for now to avoid a breaking change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@logonoff logonoff force-pushed the CONSOLE-4840-s2e11-booze-cruise branch 2 times, most recently from 030378d to 51e2f2f Compare November 6, 2025 03:10
@openshift-ci openshift-ci bot added the component/topology Related to topology label Nov 6, 2025
spadgett
spadgett approved these changes Nov 6, 2025
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/label plugin-api-approved

@openshift-ci openshift-ci bot added plugin-api-approved Indicates a PR with plugin API changes has been approved by an API reviewer lgtm Indicates that a PR is ready to be merged. labels Nov 6, 2025
@logonoff
Copy link
Member Author

logonoff commented Nov 6, 2025

/assign @yapei

@logonoff
Copy link
Member Author

logonoff commented Nov 6, 2025

/label px-approved
/label docs-approved

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Nov 6, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 6, 2025 •
edited by openshift-ci bot
Loading

@logonoff: This pull request references CONSOLE-4840 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

All ModelDefinition and FeatureFlag/Model extensions have been removed, so we can also remove their handling.

Fixes #15653 (comment)

API change:

  • ModelDefinition static extension type no longer exported to dynamic plugin SDK
  • Exported dynamic plugin SDK function setPluginStore no longer does anything -- will remove in 4.22. Decided to keep it as a stub function for now to avoid a breaking change

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@logonoff logonoff force-pushed the CONSOLE-4840-s2e11-booze-cruise branch from 73f57b3 to 51c393d Compare November 7, 2025 00:11
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 7, 2025

@logonoff: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@yapei
Copy link
Contributor

yapei commented Nov 7, 2025

the described issue in #15653 has been fixed
also performed some testing about dynamic plugin, no regression issues found
/verified by @yapei

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Nov 7, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 7, 2025

@yapei: This PR has been marked as verified by @yapei.

Details

In response to this:

the described issue in #15653 has been fixed
also performed some testing about dynamic plugin, no regression issues found
/verified by @yapei

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jhadvig
jhadvig approved these changes Nov 7, 2025
View reviewed changes
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, logonoff, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 9efb576 into openshift:main Nov 7, 2025
8 checks passed
@logonoff logonoff deleted the CONSOLE-4840-s2e11-booze-cruise branch November 7, 2025 14:04
@logonoff logonoff mentioned this pull request Nov 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spadgett spadgett spadgett approved these changes

@jhadvig jhadvig jhadvig approved these changes

@Leo6Leo Leo6Leo Awaiting requested review from Leo6Leo

Assignees

@vojtechszocs vojtechszocs

@spadgett spadgett

@jhadvig jhadvig

@yapei yapei

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/sdk Related to console-plugin-sdk component/topology Related to topology docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. plugin-api-approved Indicates a PR with plugin API changes has been approved by an API reviewer plugin-api-changed Categorizes a PR as containing plugin API changes px-approved Signifies that Product Support has signed off on this PR verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@logonoff @openshift-ci-robot @yapei @spadgett @jhadvig @vojtechszocs