Improve nav item extensions #1584
Conversation
openshift-ci-robot
added
the
size/XXL
There was a problem hiding this comment.
The reason for moving this extension up in the list is to highlight that each plugin should start with adding its own feature flag(s).
Other extensions like nav items should be gated by those feature flags.
There was a problem hiding this comment.
This link is equivalent to
<ResourceClusterLink
resource="projects"
name="Test ResourceCluster Link"
required={[FLAGS.OPENSHIFT, 'TEST_MODEL_FLAG']}
/>
|
@jtomasek This addresses the issue of adding nav items to all known sections. |
|
This PR is based on #1528 (not merged yet) so the first commit isn't related to this PR. |
|
/retest |
There was a problem hiding this comment.
Not new, but I'd like to get away from using inheritance in the nav components. Not necessary for this PR, just an observation.
openshift-ci-robot
added
the
approved
I'm on it. |
vojtechszocs
force-pushed
the
improve-nav-extension
branch
from
5fe63c9 to
ed7595e
Compare
openshift-ci-robot
added
size/XL
|
Clean rebase, no conflicts. |
Weird, there's no community type in the error screenshot. @alecmerdler fyi |
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spadgett, vojtechszocs The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5 participants
Follow-up to PR #1528.
From plugin perspective:
sectionnow links to all known sectionscomponentPropsnow links to corresponding React component propsResourceClusterNavItemextensionFrom Console perspective:
public/components/nav/index.jsxinto smaller parts that use TypeScript__REDUX_DEVTOOLS_EXTENSION_COMPOSE__to globalWindowdeclaration