Skip to content

Addition of skeleton screen for catalog and operatorhub tile views #1608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
May 29, 2019
Merged

Addition of skeleton screen for catalog and operatorhub tile views #1608

openshift-merge-robot merged 1 commit into from
May 29, 2019

Conversation

@sg00dwin
Copy link
Member

@sg00dwin sg00dwin commented May 23, 2019

loading-skeleton-catalog

@sg00dwin sg00dwin requested review from rhamilto and spadgett May 23, 2019 14:30
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 23, 2019
@spadgett
Copy link
Member

spadgett commented May 23, 2019

/assign @rhamilto

rhamilto
rhamilto reviewed May 23, 2019
View reviewed changes
Copy link
Member

@rhamilto rhamilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, @sg00dwin. A few comments.

frontend/public/components/catalog/catalog-page.jsx Outdated
Copy link
Member

@rhamilto rhamilto May 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this should be named SkeletonCatalog since there are other skeletons?

Copy link
Member

@spadgett spadgett May 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit on the suggested name, we should avoid capital in the first letter since it's not actually a component, just a dom node

Copy link
Member Author

@sg00dwin sg00dwin May 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed to skeletonCatalog

frontend/public/components/utils/_skeleton-screen.scss Outdated
Copy link
Member

@rhamilto rhamilto May 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: pseudo elements use a double colon

frontend/public/components/utils/_skeleton-screen.scss Outdated
Copy link
Member

@rhamilto rhamilto May 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: pseudo elements use a double colon

Copy link
Member

@rhamilto rhamilto May 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other pseudo elements are nested. Would be good to be consistent.

frontend/public/components/factory/list.tsx Outdated
Copy link
Member

@rhamilto rhamilto May 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this should be named SkeletonTable since there are other skeletons?

Copy link
Member Author

@sg00dwin sg00dwin May 28, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed to skeletonTable

@spadgett spadgett added this to the v4.2 milestone May 23, 2019
@sg00dwin sg00dwin force-pushed the catalog-skeleton-screen branch from 168ceda to 1357b8f Compare May 28, 2019 15:43
@sg00dwin
Copy link
Member Author

sg00dwin commented May 28, 2019

@rhamilto PTAL

rhamilto
rhamilto reviewed May 28, 2019
View reviewed changes
Copy link
Member

@rhamilto rhamilto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 28, 2019
@openshift-bot
Copy link
Contributor

openshift-bot commented May 28, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@spadgett
Copy link
Member

spadgett commented May 28, 2019 

/go/src/github.com/openshift/console/frontend/public/components/catalog/catalog-page.jsx
   38:7  error  Missing semicolon                             semi
  284:1  error  Expected indentation of 6 spaces but found 8  indent
  286:1  error  Expected indentation of 6 spaces but found 8  indent

✖ 3 problems (3 errors, 0 warnings)
  3 errors and 0 warnings potentially fixable with the `--fix` option.

/lgtm cancel
to avoid retests until the lint errors are fixed

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label May 28, 2019
@sg00dwin sg00dwin force-pushed the catalog-skeleton-screen branch from 1357b8f to f16ca02 Compare May 28, 2019 17:27
@sg00dwin
Copy link
Member Author

sg00dwin commented May 28, 2019

/retest

gallettilance
gallettilance approved these changes May 28, 2019
View reviewed changes
Copy link
Contributor

@gallettilance gallettilance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@spadgett
Copy link
Member

spadgett commented May 29, 2019

/retest

@sg00dwin
Copy link
Member Author

sg00dwin commented May 29, 2019

@spadgett ready for lgtm

@rhamilto
Copy link
Member

rhamilto commented May 29, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 29, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 29, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: galletti94, rhamilto, sg00dwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit b97634e into openshift:master May 29, 2019
@sg00dwin sg00dwin deleted the catalog-skeleton-screen branch May 30, 2019 17:45
@spadgett spadgett mentioned this pull request Jun 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhamilto rhamilto rhamilto left review comments

@spadgett spadgett Awaiting requested review from spadgett

@zherman0 zherman0 Awaiting requested review from zherman0

+1 more reviewer

@gallettilance gallettilance gallettilance approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rhamilto rhamilto

@spadgett spadgett

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

v4.2

Development

Successfully merging this pull request may close these issues.

7 participants

@sg00dwin @spadgett @openshift-bot @rhamilto @openshift-ci-robot @gallettilance @openshift-merge-robot