Skip to content

OCPBUGS-77204: Override appendTo only if needed #16108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 2 commits into from
Apr 3, 2026
Merged

OCPBUGS-77204: Override appendTo only if needed #16108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8f3cab
OCPBUGS-77204: Override `appendTo` only if needed
logonoff Apr 1, 2026
f36f906
OCPBUGS-77204: Bump PF to latest z-stream
logonoff Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions frontend/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,17 +152,17 @@
"@patternfly/patternfly": "~6.4.0",
"@patternfly/quickstarts": "~6.4.0",
"@patternfly/react-catalog-view-extension": "~6.3.0",
"@patternfly/react-charts": "~8.4.0",
"@patternfly/react-code-editor": "~6.4.0",
"@patternfly/react-charts": "~8.4.1",
"@patternfly/react-code-editor": "~6.4.2",
"@patternfly/react-component-groups": "~6.4.0",
"@patternfly/react-core": "~6.4.0",
"@patternfly/react-core": "~6.4.2",
"@patternfly/react-data-view": "~6.4.0-prerelease.12",
"@patternfly/react-drag-drop": "~6.5.0-prerelease.38",
"@patternfly/react-icons": "~6.4.0",
"@patternfly/react-log-viewer": "~6.3.0",
"@patternfly/react-styles": "~6.4.0",
"@patternfly/react-table": "~6.4.0",
"@patternfly/react-templates": "~6.4.0",
"@patternfly/react-table": "~6.4.2",
"@patternfly/react-templates": "~6.4.2",
"@patternfly/react-tokens": "~6.4.0",
"@patternfly/react-topology": "~6.4.0",
"@patternfly/react-user-feedback": "~6.2.0",
Expand Down
8 changes: 5 additions & 3 deletions frontend/public/components/utils/resource-log.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,8 @@ const LogControls: FC<LogControlsProps> = ({
const [isLogTypeOpen, setIsLogTypeOpen] = useState(false);
const [isOptionsOpen, setIsOptionsOpen] = useState(false);

const toolbarId = `resource-log-toolbar-${resource?.metadata?.name || 'unknown'}`;

const logTypes: Array<LogType> = [
{ type: LOG_TYPE_CURRENT, text: t('Current log') },
{ type: LOG_TYPE_PREVIOUS, text: t('Previous log') },
Expand Down Expand Up @@ -270,7 +272,7 @@ const LogControls: FC<LogControlsProps> = ({
onOpenChange={(isOpen) => setIsLogTypeOpen(isOpen)}
isOpen={isLogTypeOpen}
popperProps={{
appendTo: 'inline', // needed for fullscreen
appendTo: isFullscreen ? () => document.getElementById(toolbarId) : undefined,
}}
Comment on lines +275 to 276
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Prevent null popper container in fullscreen append path.

At Line 277 and Line 361, document.getElementById(toolbarId) can return null during rapid unmount/remount transitions. Add a safe fallback container to avoid intermittent crashes.

Proposed fix 
+  const getPopperContainer = useCallback(
+    () => document.getElementById(toolbarId) ?? document.body,
+    [toolbarId],
+  );
...
         popperProps={{
-          appendTo: isFullscreen ? () => document.getElementById(toolbarId) : undefined,
+          appendTo: isFullscreen ? getPopperContainer : undefined,
         }}
...
       popperProps={{
-        appendTo: isFullscreen ? () => document.getElementById(toolbarId) : undefined,
+        appendTo: isFullscreen ? getPopperContainer : undefined,
       }}

Also applies to: 361-362

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@frontend/public/components/utils/resource-log.tsx` around lines 277 - 278,
The appendTo callback can return null when document.getElementById(toolbarId) is
not found during rapid transitions; update the appendTo for the fullscreen path
to return a non-null fallback (e.g., document.body or a created fallback
element) so Popper never receives null. Specifically modify the appendTo that
currently uses () => document.getElementById(toolbarId) (and the similar
occurrence around the toolbarId use at the other location) to check for a found
element and fallback to document.body (or a persistent container) before
returning.

>
<SelectList>
Expand Down Expand Up @@ -354,7 +356,7 @@ const LogControls: FC<LogControlsProps> = ({
onOpenChange={setIsOptionsOpen}
isOpen={isOptionsOpen}
popperProps={{
appendTo: 'inline', // needed for fullscreen
appendTo: isFullscreen ? () => document.getElementById(toolbarId) : undefined,
}}
>
<SelectList>
Expand Down Expand Up @@ -410,7 +412,7 @@ const LogControls: FC<LogControlsProps> = ({
));

return (
<Toolbar data-test="resource-log-toolbar">
<Toolbar data-test="resource-log-toolbar" id={toolbarId}>
<ToolbarContent>
<ToolbarGroup className="pf-v6-u-display-flex pf-v6-u-flex-direction-column pf-v6-u-flex-direction-row-on-md pf-v6-u-w-100">
<ToolbarGroup align={{ default: 'alignStart' }}>
Expand Down
58 changes: 29 additions & 29 deletions frontend/yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3435,14 +3435,14 @@ __metadata:
languageName: node
linkType: hard

"@patternfly/react-charts@npm:~8.4.0":
version: 8.4.0
resolution: "@patternfly/react-charts@npm:8.4.0"
"@patternfly/react-charts@npm:~8.4.1":
version: 8.4.1
resolution: "@patternfly/react-charts@npm:8.4.1"
dependencies:
"@patternfly/react-styles": "npm:^6.4.0"
"@patternfly/react-tokens": "npm:^6.4.0"
hoist-non-react-statics: "npm:^3.3.2"
lodash: "npm:^4.17.21"
lodash: "npm:^4.17.23"
tslib: "npm:^2.8.1"
peerDependencies:
echarts: ^5.6.0 || ^6.0.0
Expand Down Expand Up @@ -3502,24 +3502,24 @@ __metadata:
optional: true
victory-zoom-container:
optional: true
checksum: 10c0/973802e8b16f59c9f0c9ae6c3c55c707ac21286c29f81740845a878e1eab161566da60abd495e74c95999c0560021eb5fe0fdae370c9bb9800867a170c643018
checksum: 10c0/ee21e446807b3c2eca91f967945b46103258aa0b7a5cebf29659317b08821df2ef83737fe3951d3155fb1b9539d49e3b741dc28e251dd09fc94b88c6cc26f802
languageName: node
linkType: hard

"@patternfly/react-code-editor@npm:~6.4.0":
version: 6.4.1
resolution: "@patternfly/react-code-editor@npm:6.4.1"
"@patternfly/react-code-editor@npm:~6.4.2":
version: 6.4.2
resolution: "@patternfly/react-code-editor@npm:6.4.2"
dependencies:
"@monaco-editor/react": "npm:^4.6.0"
"@patternfly/react-core": "npm:^6.4.1"
"@patternfly/react-core": "npm:^6.4.2"
"@patternfly/react-icons": "npm:^6.4.0"
"@patternfly/react-styles": "npm:^6.4.0"
react-dropzone: "npm:14.3.5"
tslib: "npm:^2.8.1"
peerDependencies:
react: ^17 || ^18 || ^19
react-dom: ^17 || ^18 || ^19
checksum: 10c0/ab64416915bc7bbb3b6656a2f4b4c3735a836a2f27390925722359587d202843d8672ae33bfcdb71b76a36bb338d175855617dac7f5a7a9c4f0bdca5c9dc1365
checksum: 10c0/fa5eee721edac343ef6e44ae8440bd676b9fd41a042c282833cfd4ae3a211d26ceb654254f894a4bca8639f93f254b0c1aa1cb47d56727412b9ad653d994a7c5
languageName: node
linkType: hard

Expand All @@ -3540,9 +3540,9 @@ __metadata:
languageName: node
linkType: hard

"@patternfly/react-core@npm:^6.0.0, @patternfly/react-core@npm:^6.0.0-prerelease.21, @patternfly/react-core@npm:^6.1.0, @patternfly/react-core@npm:^6.4.0, @patternfly/react-core@npm:^6.4.1, @patternfly/react-core@npm:^6.5.0-prerelease.37, @patternfly/react-core@npm:~6.4.0":
version: 6.4.1
resolution: "@patternfly/react-core@npm:6.4.1"
"@patternfly/react-core@npm:^6.0.0, @patternfly/react-core@npm:^6.0.0-prerelease.21, @patternfly/react-core@npm:^6.1.0, @patternfly/react-core@npm:^6.4.0, @patternfly/react-core@npm:^6.4.2, @patternfly/react-core@npm:^6.5.0-prerelease.37, @patternfly/react-core@npm:~6.4.2":
version: 6.4.2
resolution: "@patternfly/react-core@npm:6.4.2"
dependencies:
"@patternfly/react-icons": "npm:^6.4.0"
"@patternfly/react-styles": "npm:^6.4.0"
Expand All @@ -3553,7 +3553,7 @@ __metadata:
peerDependencies:
react: ^17 || ^18 || ^19
react-dom: ^17 || ^18 || ^19
checksum: 10c0/204b2b9f2990b0f0f5d907ba9d63f4f78f8691c8a4c7c292318978c5d4ea2dea89dab962be20e97bc3f2fd5172f2ee44abc17683c2c96f8f7eeb8ad357ba9326
checksum: 10c0/e6a30591bf29bfa0295cf94c546c6aa31e2643d022db48b49dabaaca928a916177aa200c4d01cb8deece8f9e1bd66d91a20b2348f0fbd84fad204a51c7919aa8
languageName: node
linkType: hard

Expand Down Expand Up @@ -3624,11 +3624,11 @@ __metadata:
languageName: node
linkType: hard

"@patternfly/react-table@npm:^6.0.0, @patternfly/react-table@npm:^6.4.0, @patternfly/react-table@npm:~6.4.0":
version: 6.4.1
resolution: "@patternfly/react-table@npm:6.4.1"
"@patternfly/react-table@npm:^6.0.0, @patternfly/react-table@npm:^6.4.0, @patternfly/react-table@npm:~6.4.2":
version: 6.4.2
resolution: "@patternfly/react-table@npm:6.4.2"
dependencies:
"@patternfly/react-core": "npm:^6.4.1"
"@patternfly/react-core": "npm:^6.4.2"
"@patternfly/react-icons": "npm:^6.4.0"
"@patternfly/react-styles": "npm:^6.4.0"
"@patternfly/react-tokens": "npm:^6.4.0"
Expand All @@ -3637,23 +3637,23 @@ __metadata:
peerDependencies:
react: ^17 || ^18 || ^19
react-dom: ^17 || ^18 || ^19
checksum: 10c0/9808a71211a70d7b5e6aead5eff49e06021bf621798e752e4c8490c1bc40a99292be877c8403fc89266aadd7299dcd3731b1354b806793b5d2e5a5db5e7d4706
checksum: 10c0/87517f3cb13dbb1c3a9d3bdabcf3469b2fb0fbdc55f1642dcc0f62029caded02ebc3822d6aa373ebc40f4782e012d0f1fc292653d438f9042c6f3ff50f4bf98b
languageName: node
linkType: hard

"@patternfly/react-templates@npm:~6.4.0":
version: 6.4.1
resolution: "@patternfly/react-templates@npm:6.4.1"
"@patternfly/react-templates@npm:~6.4.2":
version: 6.4.2
resolution: "@patternfly/react-templates@npm:6.4.2"
dependencies:
"@patternfly/react-core": "npm:^6.4.1"
"@patternfly/react-core": "npm:^6.4.2"
"@patternfly/react-icons": "npm:^6.4.0"
"@patternfly/react-styles": "npm:^6.4.0"
"@patternfly/react-tokens": "npm:^6.4.0"
tslib: "npm:^2.8.1"
peerDependencies:
react: ^17 || ^18 || ^19
react-dom: ^17 || ^18 || ^19
checksum: 10c0/c4563149d59f4c1b02069c737f63fc47f741b22afd6daab97512717c0482cbcd2d3884fd263f6739095cf56eba0447719893f987c2b93165d4881fffbc5e1eed
checksum: 10c0/fabe5ac68419a97201fa7334d6f20d2cecb61f9408ef073907dc6bb6103c1be912b1c6f77972810350525d3ccf695c28705c2e402716029c1e82fc27b291028f
languageName: node
linkType: hard

Expand Down Expand Up @@ -17421,17 +17421,17 @@ __metadata:
"@patternfly/patternfly": "npm:~6.4.0"
"@patternfly/quickstarts": "npm:~6.4.0"
"@patternfly/react-catalog-view-extension": "npm:~6.3.0"
"@patternfly/react-charts": "npm:~8.4.0"
"@patternfly/react-code-editor": "npm:~6.4.0"
"@patternfly/react-charts": "npm:~8.4.1"
"@patternfly/react-code-editor": "npm:~6.4.2"
"@patternfly/react-component-groups": "npm:~6.4.0"
"@patternfly/react-core": "npm:~6.4.0"
"@patternfly/react-core": "npm:~6.4.2"
"@patternfly/react-data-view": "npm:~6.4.0-prerelease.12"
"@patternfly/react-drag-drop": "npm:~6.5.0-prerelease.38"
"@patternfly/react-icons": "npm:~6.4.0"
"@patternfly/react-log-viewer": "npm:~6.3.0"
"@patternfly/react-styles": "npm:~6.4.0"
"@patternfly/react-table": "npm:~6.4.0"
"@patternfly/react-templates": "npm:~6.4.0"
"@patternfly/react-table": "npm:~6.4.2"
"@patternfly/react-templates": "npm:~6.4.2"
"@patternfly/react-tokens": "npm:~6.4.0"
"@patternfly/react-topology": "npm:~6.4.0"
"@patternfly/react-user-feedback": "npm:~6.2.0"
Expand Down