Skip to content

Revert "OCPBUGS-74156: Prevent pod log viewer from shifting page layout when searching"#16218

Merged
openshift-merge-bot[bot] merged 1 commit intomainfrom
revert-16193-OCPBUGS-74156-pod-log-container-shifts-position
Apr 3, 2026
Merged

Revert "OCPBUGS-74156: Prevent pod log viewer from shifting page layout when searching"#16218
openshift-merge-bot[bot] merged 1 commit intomainfrom
revert-16193-OCPBUGS-74156-pod-log-container-shifts-position

Conversation

@rhamilto
Copy link
Copy Markdown
Member

@rhamilto rhamilto commented Mar 30, 2026

Reverts #16193

Summary by CodeRabbit

  • Refactor
    • Removed an unnecessary CSS override that was managing drawer behavior in specific scenarios.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 30, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@rhamilto: This pull request references Jira Issue OCPBUGS-74156, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Reverts #16193

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from TheRealJon and sg00dwin March 30, 2026 14:11
@openshift-ci openshift-ci bot added component/core Related to console core functionality approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 30, 2026
@rhamilto
Copy link
Copy Markdown
Member Author

/approve
/assign @sg00dwin

@rhamilto
Copy link
Copy Markdown
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 30, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@rhamilto: This pull request references Jira Issue OCPBUGS-74156, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from yapei March 30, 2026 14:12
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@rhamilto: This pull request references Jira Issue OCPBUGS-74156, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

Details

In response to this:

Reverts #16193

Summary by CodeRabbit

  • Refactor
  • Removed an unnecessary CSS override that was managing drawer behavior in specific scenarios.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 30, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: c95e286d-244e-447f-8dc8-49f0b887179b

📥 Commits

Reviewing files that changed from the base of the PR and between 46a9c16 and e18ddad.

📒 Files selected for processing (1)
  • frontend/public/style/_overrides.scss
💤 Files with no reviewable changes (1)
  • frontend/public/style/_overrides.scss

📝 Walkthrough

Walkthrough

A CSS workaround targeting the PatternFly v6 drawer main container (#content .pf-v6-c-drawer__main) has been removed from the style overrides file. The rule previously applied overflow: clip to mitigate horizontal scrolling behavior triggered by scrollIntoView operations during pod-log searching when line wrapping was disabled. No replacement styling or alternative mitigation logic was introduced in this change.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch revert-16193-OCPBUGS-74156-pod-log-container-shifts-position

Comment @coderabbitai help to get the list of available commands and usage tips.

@sg00dwin sg00dwin added the verified Signifies that the PR passed pre-merge verification criteria label Mar 30, 2026
Copy link
Copy Markdown
Member

@sg00dwin sg00dwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 30, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 30, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, sg00dwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 2e67298 and 2 for PR HEAD e18ddad in total

@rhamilto
Copy link
Copy Markdown
Member Author

/retest

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 3d26f42 and 1 for PR HEAD e18ddad in total

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD a647310 and 0 for PR HEAD e18ddad in total

@openshift-merge-bot
Copy link
Copy Markdown
Contributor

/hold

Revision e18ddad was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 1, 2026
@galkremer1
Copy link
Copy Markdown
Member

/retest

@rhamilto
Copy link
Copy Markdown
Member Author

rhamilto commented Apr 2, 2026

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 2, 2026
@rhamilto
Copy link
Copy Markdown
Member Author

rhamilto commented Apr 2, 2026

/retest

1 similar comment
@rhamilto
Copy link
Copy Markdown
Member Author

rhamilto commented Apr 2, 2026

/retest

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Apr 3, 2026

@rhamilto: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 89b5685 into main Apr 3, 2026
8 checks passed
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@rhamilto: Jira Issue OCPBUGS-74156: Some pull requests linked via external trackers have merged:

The following pull request, linked via external tracker, has not merged:

All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-74156 has not been moved to the MODIFIED state.

This PR is marked as verified. If the remaining PRs listed above are marked as verified before merging, the issue will automatically be moved to VERIFIED after all of the changes from the PRs are available in an accepted nightly payload.

Details

In response to this:

Reverts #16193

Summary by CodeRabbit

  • Refactor
  • Removed an unnecessary CSS override that was managing drawer behavior in specific scenarios.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@rhamilto rhamilto deleted the revert-16193-OCPBUGS-74156-pod-log-container-shifts-position branch April 3, 2026 11:40
@openshift-merge-robot
Copy link
Copy Markdown
Contributor

Fix included in accepted release 4.22.0-0.nightly-2026-04-04-113332

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants