Skip to content

Change namespace bar Add actions to only Import YAML #1706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jun 12, 2019
Merged

Change namespace bar Add actions to only Import YAML #1706

openshift-merge-robot merged 1 commit into from
Jun 12, 2019

Conversation

@rhamilto
Copy link
Member

@rhamilto rhamilto commented Jun 12, 2019

I made the link the text color as having it link color was a bit too prominent IMO. I maintained the link hover color, however.

Screen Shot 2019-06-12 at 1 24 13 PM
hover
Screen Shot 2019-06-12 at 1 24 24 PM

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 12, 2019
@rhamilto rhamilto mentioned this pull request Jun 12, 2019
Merged
4 tasks
@spadgett
Copy link
Member

spadgett commented Jun 12, 2019

cc @beanh66

spadgett
spadgett approved these changes Jun 12, 2019
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 12, 2019
@rhamilto rhamilto force-pushed the namespace-bar-actions branch from 6d862f7 to 833e822 Compare June 12, 2019 17:59
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jun 12, 2019
@rhamilto
Copy link
Member Author

rhamilto commented Jun 12, 2019

Linter errors fixed. @spadgett, PTAL.

@spadgett
Copy link
Member

spadgett commented Jun 12, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 12, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 12, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 7fd2b42 into openshift:master Jun 12, 2019
@rhamilto rhamilto deleted the namespace-bar-actions branch June 12, 2019 19:43
@spadgett spadgett added this to the v4.2 milestone Jun 13, 2019
@beanh66
Copy link

beanh66 commented Jun 13, 2019

@rhamilto Thanks, make sense! Minor question, on hover can we add the underline as well?

@rhamilto
Copy link
Member Author

rhamilto commented Jun 13, 2019

@rhamilto Thanks, make sense! Minor question, on hover can we add the underline as well?

Done in #1715

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spadgett spadgett spadgett approved these changes

@jcaianirh jcaianirh Awaiting requested review from jcaianirh

@kyoto kyoto Awaiting requested review from kyoto

Assignees

@spadgett spadgett

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

v4.2

Development

Successfully merging this pull request may close these issues.

5 participants

@rhamilto @spadgett @openshift-ci-robot @beanh66 @openshift-merge-robot