[WIP]Kubevirt VmTemplateDetails

[yaacov]

Introduces Details Page for Virtual Machine Templates.

Depends on:

• Kubevirt VmTemplateList #1673 - List Page for Virtual Machine Templates.

Ref:
#1682

[yaacov]

/retest

[spadgett]

This should be implemented as a special route instead of a resource page since we still need to handle templates that aren't VM templates.

cc @vojtechszocs

[spadgett]

You shouldn't override the existing template model. It's already defined.

[yaacov]

@spadgett Thanks, this comment should be in:
https://github.com/openshift/console/pull/1673/files#diff-8066fd03cba594c7f8fb2be0890b95f9L55

This PR requires #1673, and this line is actually from the other PR.

I will adress this issue in #1673 👍

[spadgett]

This shouldn't be a resource page since we have an existing resource page for templates (and not all templates are VM templates). This will need to be a special route.

[yaacov]

Thanks, 👍 will address this in #1673 :-)

[spadgett]

This will override the default template YAML, which we don't want.

[yaacov]

Yes, I know ... see #1673 (comment) and #1673 (comment)

@spadgett Do we have other option to set specialized yaml if path is .../vmtemplates/~new ?

👍 also will address in #1673 :-)

[vojtechszocs]

This will override the default template YAML, which we don't want.

@spadgett @yaacov FYI, we already have an extension check to cover this:

packages/console-app/src/__tests__/extension-checks/yaml-templates.spec.ts

So even if a plugin tries to override an existing YAML template (modelRef & templateName composite key), yarn test still fails due to only one named template per model is allowed.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@yaacov: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/prow/backend	78628d9	link	/test backend
ci/prow/frontend	78628d9	link	/test frontend
ci/prow/e2e-aws-console-olm	78628d9	link	/test e2e-aws-console-olm
ci/prow/e2e-aws	78628d9	link	/test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.