-
Notifications
You must be signed in to change notification settings - Fork 667
expose build AccessReview functionality #1779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
expose build AccessReview functionality #1779
Conversation
|
Hi @suomiy. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be better in frontend/public/components/utils/rbac.tsx since it's not specific to kebabs.
I would call kind either model or kindObj to avoid confusion with a kind string. (Upstream uses kind to refer to strings like 'Pod'.) I know this is what we use kind below in the kebab functions below, but we should try to be more precise in new code.
buildAccessReview sounds like a review for a Build resource. Maybe something like toAccessReview / asAccessReview / makeAccessReview ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, moved and renamed
026d79c to
13a6537
Compare
13a6537 to
323f799
Compare
spadgett
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
/ok-to-test |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
/lgtm cancel /approve |
323f799 to
450dc5e
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spadgett, suomiy The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
expose build AccessReview functionality
this helper comes useful when implementing custom actions (could be used by #1761)
not sure about the location though