[WIP] Created extension for OCS operator workflow for IPI #1809
Conversation
openshift-ci-robot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: gnehapk The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @gnehapk. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
needs-ok-to-test
| > | ||
| <ModalTitle>Create OCS Service</ModalTitle> | ||
| <ModalBody> | ||
| 3 new nodes and a AWS bucket will be created in order to create the OCS Service. |
There was a problem hiding this comment.
I'd suggest handling this via some message prop instead of using a hard-coded text 😃
|
|
||
| export const ipiDeployementModal = createModalLauncher<ipiModalProps>(IPIDeployementModal); | ||
|
|
||
| export type ipiModalProps = { |
There was a problem hiding this comment.
Please use <ComponentName>Props, i.e. this should be IPIDeployementModalProps.
| } from '@console/internal/components/utils/promise-component'; | ||
|
|
||
| class IPIDeployementModal extends PromiseComponent<ipiModalProps, PromiseComponentState> { | ||
| state = { |
There was a problem hiding this comment.
Please mark the state as readonly and use the appropriate type.
readonly state: IPIDeployementModalState = ...
| PromiseComponentState, | ||
| } from '@console/internal/components/utils/promise-component'; | ||
|
|
||
| class IPIDeployementModal extends PromiseComponent<ipiModalProps, PromiseComponentState> { |
There was a problem hiding this comment.
The PromiseComponentState type is currently used only in promise-component.spec.tsx.
I think that each modal component should explicitly declare its own state type, i.e. please add this after the props type:
type IPIDeployementModalState = {
inProgress: boolean;
errorMessage: string;
};
|
Sent out a new PR after the new design changes. Hence, closing this PR |
4 participants
After implementing, the IPI modal looks like -
@spadgett @vojtechszocs This is the initial PR of OCS operator workflow for IPI. Please review.