Add Inventory card

[rawagner]

Plugins can contribute new items to Inventory tab and also new status groups via DashboardsOverviewInventoryItem and DashboardsInventoryItemGroup extension points.

Every status group is a link pointing to resource page with enabled filters (ie Pods in OK group will link to Pods page with 'Running and Succeeded status).

[openshift-ci-robot]

Hi @rawagner. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[vojtechszocs]

Plugins can contribute new items to Inventory tab

... to Cluster Inventory card within the Overview tab 😃

[vojtechszocs]

It seems that resource.kind value can fall back to model.kind unless the developer wants to be explicit about it.

More generally, we should try to keep the extension properties (API surface) as small and lean as possible.

With these typings added to public/declarations.d.ts (source):

type OptionalExceptFor<T, K extends keyof T> = Partial<T> & Pick<T, K>;
type RequiredExceptFor<T, K extends keyof T> = Pick<T, Diff<keyof T, K>> & Partial<T>;

We can now modify resource.kind to be optional:

resource: RequiredExceptFor<FirehoseResource, 'kind'>;

which makes the extension properties declaration shorter.

[rawagner]

RequiredExceptFor definition isn't correct as we are using different Diff definition than expected. Sticking to FirehoseResource for now

[vojtechszocs]

OK, we can improve this later on.

[vojtechszocs]

Please rename this property to icon to better reflect its purpose.

[vojtechszocs]

Based on discussion, please change the type to React.ReactElement - similar to Perspective.icon.

[rawagner]

isnt React.ReactNode more appropriate here ? I could also rename icon to Icon to sign that it is React component.

[rawagner]

Using React.ReactElement same as in Perspective.icon

[spadgett]

/assign @vojtechszocs

[spadgett]

/approve

Approving pending lgtm from @vojtechszocs

[spadgett]

/ok-to-test

[rawagner]

@vojtechszocs as per our discussion I removed plugin-stats from package.json. Can you take a look ?

[rawagner]

@vojtechszocs as per our discussion I removed plugin-stats from package.json. Can you take a look ?

added back sice #1871 is up

[rawagner]

/test e2e-aws

[vojtechszocs]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rawagner, spadgett, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• frontend/OWNERS [spadgett]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.