Skip to content

Use unique reference in redux ID #1816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jun 29, 2019
Merged

Use unique reference in redux ID #1816

openshift-merge-robot merged 1 commit into from
Jun 29, 2019

Conversation

@spadgett
Copy link
Member

@spadgett spadgett commented Jun 25, 2019

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 25, 2019
@alecmerdler
Copy link
Contributor

alecmerdler commented Jun 25, 2019

Of course this would be the cause. We've needed this for a while. Good catch.

@spadgett spadgett changed the title [WIP] Use unique reference in redux ID Use unique reference in redux ID Jun 25, 2019
@spadgett spadgett added this to the v4.2 milestone Jun 25, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 25, 2019
@spadgett
Copy link
Member Author

spadgett commented Jun 26, 2019

/retest

@invincibleJai
Copy link
Member

invincibleJai commented Jun 26, 2019

@spadgett sure i'll do it, i was about to file a separate PR as #1800 has lot of other changes

and adding kind in id would make it unique.

invincibleJai
invincibleJai approved these changes Jun 26, 2019
View reviewed changes
Copy link
Member

@invincibleJai invincibleJai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@invincibleJai
Copy link
Member

invincibleJai commented Jun 26, 2019

Looks good to me, verified !!

Screenshot 2019-06-26 at 8 00 13 AM

@christianvogt
Copy link
Contributor

christianvogt commented Jun 26, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2019
@spadgett
Copy link
Member Author

spadgett commented Jun 26, 2019

@alecmerdler It looks like there are cases where k8sKind is undefined in makeReduxID (at least the Installed Operators page). I'm investigating.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 26, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@christianvogt
Copy link
Contributor

christianvogt commented Jun 26, 2019

@spadgett if it were undefined, then the old code would have also been failing.

@spadgett
Copy link
Member Author

spadgett commented Jun 26, 2019

@spadgett if it were undefined, then the old code would have also been failing.

It is sometimes undefined, but digging deeper that doesn't seem to be the problem. Looks like it's the check here:

https://github.com/spadgett/console/blob/cd47343e287bd07b5ab721da51e4afcb07295fdc/frontend/public/components/operator-lifecycle-manager/clusterserviceversion.tsx#L127

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 26, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@spadgett
Copy link
Member Author

spadgett commented Jun 26, 2019

@alecmerdler I don't believe the check is needed anymore after #776. We should be able to remove that stateToProps entirely. I see no flicker.

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 26, 2019
@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 27, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@spadgett
Copy link
Member Author

spadgett commented Jun 27, 2019

/retest

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 27, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 27, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 28, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@spadgett
Copy link
Member Author

spadgett commented Jun 28, 2019

/hold
to prevent retest. vertical pod autoscaler broke e2e-aws earlier today

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 28, 2019
@spadgett
Copy link
Member Author

spadgett commented Jun 28, 2019

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 28, 2019
@spadgett
Copy link
Member Author

spadgett commented Jun 28, 2019

/retest

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 28, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

18 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 28, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 28, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 29, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 29, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 29, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 29, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 29, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 29, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 29, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 29, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 29, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 29, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 29, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 29, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 29, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 29, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 29, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 29, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit da0b855 into openshift:master Jun 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@invincibleJai invincibleJai invincibleJai approved these changes

@alecmerdler alecmerdler alecmerdler approved these changes

@christianvogt christianvogt christianvogt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@alecmerdler alecmerdler

@christianvogt christianvogt

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

v4.2

Development

Successfully merging this pull request may close these issues.

7 participants

@spadgett @alecmerdler @invincibleJai @christianvogt @openshift-bot @openshift-ci-robot @openshift-merge-robot