Move yaml tempalte to models dir #1842
Conversation
openshift-ci-robot
added
the
size/XS
|
This was requested by @vojtechszocs @suomiy . @mareklibra @vojtechszocs @suomiy @rawagner please review. |
There was a problem hiding this comment.
can we go one level deeper into models/templates/ and have a separate file for each template?
There was a problem hiding this comment.
make sense to me too ... 👍
openshift-ci-robot
added
size/M
yaacov
force-pushed
the
move-yaml-templates
branch
from
225433a to
bef2876
Compare
| .setIn( | ||
| [TemplateModel, 'vm-template'], | ||
| ` | ||
| export const VmTemplateYAMLTemplates = ImmutableMap().setIn( |
There was a problem hiding this comment.
please rename to either VirtualMachineTemplate... or VMTemplate...
openshift-ci-robot
added
the
approved
| @@ -0,0 +1,2 @@ | |||
| export * from './vm-template-yaml-templates'; | |||
| export * from './vm-yaml-templates'; | |||
There was a problem hiding this comment.
nit: as this is already under models/templates, do we need the extra -templates at the end of the filename?
mareklibra
left a comment
mareklibra
left a comment
There was a problem hiding this comment.
Left small comment, otherwise lgtm
|
/retest |
1 similar comment
|
/retest |
|
/test e2e-aws |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: suomiy, yaacov The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/retest |
1 similar comment
|
/retest |
|
/test e2e-aws |
|
/retest |
1 similar comment
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
8 participants
Move kubevirt-plugin models into a separate dir.
Ref:
#1673 (comment)