-
Notifications
You must be signed in to change notification settings - Fork 667
add Knative plugin #1901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Knative plugin #1901
Conversation
|
@christianvogt Do we plan to put some tech-preview badge / indicator on it? |
|
@sspeiche we can add a tech preview badge if needed cc @openshift/team-devconsole-ux I'd prefer to do any customizations in a separate PR because this PR simply first enables the default pages. We plan to update the pages to be customized lists with custom columns later. We can add the badges there if needed. |
93e11ef to
3466462
Compare
|
@vojtechszocs i got the following error, so I removed |
7c1f21b to
55ea82c
Compare
|
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we move this util as well under knative-plugin, WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could. Since the util isn't being used yet and after our discussion I wasn't sure if it was going to be updated to align more closely with the forms apis or not.
For now I'll leave it here and you can move it when you get to completing the work on the import forms.
55ea82c to
16e94c3
Compare
|
rebased |
16e94c3 to
dd57081
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
am not sure how abbr works but when i try store.getState().k8s.toJS().RESOURCES.models['serving.knative.dev~v1alpha1~KnativeServing'] in browser console registered model has KS as abbr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
labelPlural: 'Knative Servings',
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
dd57081 to
6b91f2f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
invincibleJai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
/lgtm |
@sspeiche @christianvogt yes we want to. We need a convention for OpenShift to do this. We will work with @beanh66 and her team early in the week to propose something and get it reviewed. |
|
FYI @alimobrem |
|
I'm fine with adding a tech preview badge in some way. But we can do so in another PR once the design is determined. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt, invincibleJai, rohitkrai03, spadgett The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I've just rebased & updated #1911 to fix that. |
Adds a new package to the monorepo for knative resources.
Serverlesssection to the admin navcc @joshuawilson @invincibleJai @vojtechszocs
fyi @alimobrem @sspeiche