kubevirt: add Actions to VM detail

[atiratree]

depends on:

• DetailsPage - pass extra resources to PageHeading Actions #1907

[vojtechszocs]

Why aren't we using e.g. React.FC type here?

Also, using the props destructuring form is much cleaner:

const Foo: React.FC<FooProps> = ({ name, namespace }) => {};

If you need direct access to props, simply use an alias when destructuring:

const Foo: React.FC<FooProps> = (props: { name, namespace }) => {};

[atiratree]

Fixed, it was not updated.

But the props still have to be there because they are passed down to the DetailsPage

[vojtechszocs]

Please avoid too many acronyms in module names.

I'd suggest to name this directory selectors/vmi-migrations (either plural or singular) instead.

"VMI" is a quite common acronym, but "VMIM" isn't.

[atiratree]

you are right; changed to vmi-migration

[atiratree]

/test e2e-aws-console-olm

[vojtechszocs]

Do we really need to export both menuActions and menuActionsCreator?

It seems that menuActionsCreator is the one who is supposed to interpret (execute) menuActions.

[atiratree]

yes we do. The use cases differ:

• vm list: the row already has status, etc computed so it just passes it to menuActions
• vm detail: Once we get detail page resources we compute the status, etc and pass it to all the actions (which is the only way how to pass logic to execute after loading resources before rendering actions)

[vojtechszocs]

I think we should add type annotations, e.g. migrations is treated as an array but the signature doesn't reflect this fact.

I'm OK doing this in a follow-up. When adding new code, always try to make use of proper TypeScript.

[atiratree]

added the types. Although K8sResourceKind instead of a Migration because we don't have the type yet (waits for type generation PR)

[atiratree]

/test frontend

[atiratree]

/test e2e-aws

[vojtechszocs]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: suomiy, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• frontend/OWNERS [vojtechszocs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[atiratree]

/test e2e-aws
/test e2e-aws-console
/test e2e-aws-console-olm