Skip to content

add warn to accessReview for null #1964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 1 commit into from
Jul 10, 2019
Merged

add warn to accessReview for null #1964

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions frontend/public/components/utils/rbac.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@ import * as React from 'react';
import { connect } from 'react-redux';
import * as _ from 'lodash-es';

import { getName, getNamespace } from '@console/shared';

import store from '../../redux';
import { impersonateStateToProps } from '../../reducers/ui';
import {
Expand Down Expand Up @@ -87,10 +89,16 @@ type RequireCreatePermissionProps = {
children: React.ReactNode;
};

export const asAccessReview = (kindObj: K8sKind, obj: K8sResourceKind, verb: K8sVerb): AccessReviewResourceAttributes => ({
group: kindObj.apiGroup,
resource: kindObj.plural,
name: obj.metadata.name,
namespace: obj.metadata.namespace,
verb,
});
export const asAccessReview = (kindObj: K8sKind, obj: K8sResourceKind, verb: K8sVerb): AccessReviewResourceAttributes => {
if (!obj){
Copy link
Member

@spadgett spadgett Jul 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return null if the obj is null

Copy link
Member

@spadgett spadgett Jul 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you don't return null here, it will make an entirely different, unintended access review check. That is my original concern with the change :)

Copy link
Member Author

@atiratree atiratree Jul 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah sorry, my bad. Fixed

console.warn('review obj should not be null'); // eslint-disable-line no-console
return null;
}
return ({
group: kindObj.apiGroup,
resource: kindObj.plural,
name: getName(obj),
namespace: getNamespace(obj),
verb,
});
};