Skip to content

pass custom data to the list, detail and actions #1965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 2 commits into from
Jul 16, 2019
Merged

pass custom data to the list, detail and actions #1965

openshift-merge-robot merged 2 commits into from
Jul 16, 2019

Conversation

@atiratree
Copy link
Member

@atiratree atiratree commented Jul 9, 2019 •
edited
Loading

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 9, 2019
@atiratree atiratree mentioned this pull request Jul 9, 2019
Merged
3 tasks
@spadgett spadgett added this to the v4.2 milestone Jul 9, 2019
@atiratree atiratree force-pushed the customData branch 2 times, most recently from d8f14e5 to 196a1ba Compare July 9, 2019 18:20
vojtechszocs
vojtechszocs suggested changes Jul 12, 2019
View reviewed changes
frontend/public/components/utils/kebab.tsx Outdated
Copy link
Contributor

@vojtechszocs vojtechszocs Jul 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This type duality isn't necessary IMO, please see #1907 (comment).

Copy link
Member Author

@atiratree atiratree Jul 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it might be necessary, please see the reply

@vojtechszocs
Copy link
Contributor

vojtechszocs commented Jul 12, 2019 •
edited
Loading

To clarify, this change is needed to pass custom data down to kebab actions within the list & details pages, i.e. Node maintenance related actions.

@spadgett FYI, this touches core Console components.

@atiratree
Copy link
Member Author

atiratree commented Jul 15, 2019

/test e2e-aws

@vojtechszocs
Copy link
Contributor

vojtechszocs commented Jul 15, 2019

Please see my recent review/comment on #1907.

Changes in this PR alone LGTM.

@vojtechszocs
Copy link
Contributor

vojtechszocs commented Jul 16, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 16, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 16, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: suomiy, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2019
@openshift-merge-robot openshift-merge-robot merged commit c5f62ca into openshift:master Jul 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhamilto rhamilto Awaiting requested review from rhamilto

@TheRealJon TheRealJon Awaiting requested review from TheRealJon

1 more reviewer

@vojtechszocs vojtechszocs vojtechszocs requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vojtechszocs vojtechszocs

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

v4.2

Development

Successfully merging this pull request may close these issues.

6 participants

@atiratree @vojtechszocs @openshift-ci-robot @spadgett @openshift-merge-robot @suomiy