Skip to content

[metal3] Introduces power actions for Baremetal hosts #2046

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jul 25, 2019
Merged

[metal3] Introduces power actions for Baremetal hosts #2046

openshift-merge-robot merged 1 commit into from
Jul 25, 2019

Conversation

@jtomasek
Copy link

@jtomasek jtomasek commented Jul 16, 2019 •
edited
Loading

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 16, 2019
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 17, 2019
@jtomasek
Copy link
Author

jtomasek commented Jul 17, 2019

/test e2e-aws-console
/test e2e-aws-console-olm

@vojtechszocs
Copy link
Contributor

vojtechszocs commented Jul 17, 2019

Had a quick look - LGTM so far.

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 18, 2019
@jtomasek jtomasek changed the title [WIP][metal3] Introduces power actions for Baremetal hosts [metal3] Introduces power actions for Baremetal hosts Jul 18, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 18, 2019
@jtomasek
Copy link
Author

jtomasek commented Jul 18, 2019

/test frontend

@jtomasek
Copy link
Author

jtomasek commented Jul 18, 2019

/test e2e-aws

@honza
Copy link
Member

honza commented Jul 19, 2019

Tiny nit: some of the strings could be extracted into constants.

@honza
Copy link
Member

honza commented Jul 19, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 19, 2019
@jelkosz
Copy link

jelkosz commented Jul 19, 2019

/test e2e-aws

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 19, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@jtomasek
Copy link
Author

jtomasek commented Jul 19, 2019

/test e2e-aws

1 similar comment
@jtomasek
Copy link
Author

jtomasek commented Jul 19, 2019

/test e2e-aws

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 19, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@spadgett spadgett added this to the v4.2 milestone Jul 19, 2019
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 19, 2019
@openshift-ci-robot openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 22, 2019
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 22, 2019
@jtomasek
Copy link
Author

jtomasek commented Jul 23, 2019

/test e2e-aws-console-olm

5 similar comments
@jtomasek
Copy link
Author

jtomasek commented Jul 23, 2019

/test e2e-aws-console-olm

@jtomasek
Copy link
Author

jtomasek commented Jul 23, 2019

/test e2e-aws-console-olm

@jtomasek
Copy link
Author

jtomasek commented Jul 23, 2019

/test e2e-aws-console-olm

@jtomasek
Copy link
Author

jtomasek commented Jul 23, 2019

/test e2e-aws-console-olm

@jtomasek
Copy link
Author

jtomasek commented Jul 24, 2019

/test e2e-aws-console-olm

@knowncitizen
Copy link
Contributor

knowncitizen commented Jul 24, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 24, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 24, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: honza, jtomasek, knowncitizen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

openshift-bot commented Jul 25, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@jtomasek
Copy link
Author

jtomasek commented Jul 25, 2019

/test e2e-aws

@openshift-merge-robot openshift-merge-robot merged commit e8431c2 into openshift:master Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kyoto kyoto Awaiting requested review from kyoto

1 more reviewer

@knowncitizen knowncitizen knowncitizen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@knowncitizen knowncitizen

@honza honza

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

v4.2

Development

Successfully merging this pull request may close these issues.

9 participants

@jtomasek @vojtechszocs @honza @jelkosz @openshift-bot @knowncitizen @openshift-ci-robot @spadgett @openshift-merge-robot