Update width if ref width changes #2058
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XS
Member
|
/assign @TheRealJon |
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rawagner, spadgett, TheRealJon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref width hook reacts only on
resizeandnav_toggleevents which in some cases may not be enough - component may get rerendered with different size but non of the mentioned events happened.Actual scenario where this is causing issues is in Grid component https://github.com/openshift/console/blob/master/frontend/public/components/dashboard/grid.tsx#L21 which on the first render renders narrow grid as width is 0 in the beginning. We have various charts as grid items and they compute their width/height also with
ref-width-hook. Second render ofgridrenders wide grid (width fromwidth-ref-hookis populated with actual value) which changes the size of cards (thus size of charts) but charts are not updated with new width because their width didnt change due toresizeornav_toggle