Add Baremetal hosts to overview dashboard inventory #2069

rawagner · 2019-07-17T14:29:14Z

@jtomasek @honza I haven't tried it so if you can, it would be great

verified, thanks @honza

rawagner · 2019-07-18T11:26:29Z

@honza @jtomasek take a look

jtomasek · 2019-07-18T11:33:51Z

frontend/packages/metal3-plugin/src/components/dashboard/utils.ts

HOST_REGISTERING_STATES and HOST_PROVISIONING_STATES are not needed as those are a subset of HOST_PROGRESS_STATES

good to know, removed redundant states

jtomasek · 2019-07-18T11:38:38Z

frontend/packages/metal3-plugin/src/components/dashboard/utils.ts

I believe the statusIDs be the host status constants from ../../constants

these statusIDs are keys in this object https://github.com/openshift/console/blob/master/frontend/packages/metal3-plugin/src/components/table-filters.ts#L14 . Most of them are in constants (missing other) but It seems to me that those constants are values which can appear in bmh status K8s object and are not meant to be IDs of status filters. Correct me if Im wrong.

You're right, thanks for clarification.

jtomasek · 2019-07-18T11:45:59Z

frontend/packages/metal3-plugin/src/components/dashboard/utils.ts

This function does not exist any more. getBMHStatusGroups will now need to take bmh and nodeMaintenance to correctly identify host status. See https://github.com/openshift/console/blob/master/frontend/packages/metal3-plugin/src/utils/host-status.ts#L57

function updated. Im fetching bmhs, nodes, hosts and node maintenances now

jtomasek

Looks good, 2 nits

jtomasek · 2019-07-18T14:11:09Z

frontend/packages/metal3-plugin/src/components/dashboard/utils.ts

Nit: renaming bmh to host would align to what we're using in other places for baremetal host variable and simplify

Suggested change

const hostMultiStatus = getHostStatus({ host: bmh, nodeMaintenance });

const hostMultiStatus = getHostStatus({ host, nodeMaintenance });

jtomasek · 2019-07-18T14:11:19Z

frontend/packages/metal3-plugin/src/components/dashboard/utils.ts

same nit as above

jtomasek · 2019-07-18T14:26:14Z

frontend/packages/metal3-plugin/src/components/dashboard/utils.ts

You're right, thanks for clarification.

rawagner · 2019-07-18T14:31:56Z

renamed bmh to host to align with rest of metal3 code.

jtomasek · 2019-07-18T14:32:37Z

/lgtm

openshift-bot · 2019-07-18T15:57:20Z

/retest

Please review the full test history for this PR and help us cut down flakes.

spadgett · 2019-07-18T17:00:43Z

/retest

spadgett · 2019-07-18T18:19:28Z

/retest

spadgett · 2019-07-18T18:28:51Z

/retest

spadgett · 2019-07-18T19:32:00Z

/retest

rawagner · 2019-07-18T20:30:09Z

/test e2e-aws
/test e2e-aws-console-olm

rawagner · 2019-07-19T05:16:17Z

/test e2e-aws
/test e2e-aws-console-olm

openshift-bot · 2019-07-19T17:35:38Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-07-19T18:40:25Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-07-21T12:24:28Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-07-21T12:37:27Z

/retest

Please review the full test history for this PR and help us cut down flakes.

spadgett · 2019-07-21T14:04:07Z

/retest

rawagner · 2019-07-21T18:02:32Z

/test e2e-aws-console-olm
/test e2e-aws-console

openshift-bot · 2019-07-21T19:08:47Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-07-21T20:12:23Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-07-21T21:17:46Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-07-21T22:23:37Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-07-21T22:35:25Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-07-21T23:27:28Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-07-21T23:40:22Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-07-22T00:19:23Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-07-22T00:32:33Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-07-22T01:23:53Z

/retest

Please review the full test history for this PR and help us cut down flakes.

spadgett · 2019-07-22T01:39:42Z

/hold

It looks something in this pr has broken the tests

rawagner · 2019-07-22T10:23:13Z

Dashboards page failed to load because there is some circular dependency when loading code from plugin.ts which depends on some code from components/utils. In this case the issue appeared after merging #1697. plugin.ts depends on code which is loading Status from console/shared and that depends on code from components/utils so I had to change imports of console/shared to more specific ones ie console/shared/src/selectors.

This is not specific to Status component as I noticed similar issue when plugin.ts depends on code from components/utils a few times before. We will need to take a closer look at the issue in the future.

rawagner · 2019-07-22T10:23:34Z

/hold cancel

atiratree · 2019-07-22T10:25:32Z

/lgtm

openshift-ci-robot · 2019-07-22T10:25:45Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jtomasek, rawagner, suomiy, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~frontend/packages/metal3-plugin/OWNERS~~ [jtomasek,vojtechszocs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 17, 2019

openshift-ci-robot requested review from honza and knowncitizen July 17, 2019 14:29

rawagner force-pushed the host-overview branch 2 times, most recently from bbbf254 to f5c51fd Compare July 18, 2019 11:25

jtomasek suggested changes Jul 18, 2019

View reviewed changes

rawagner force-pushed the host-overview branch from f5c51fd to ddc072a Compare July 18, 2019 13:28

openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 18, 2019

jtomasek suggested changes Jul 18, 2019

View reviewed changes

rawagner force-pushed the host-overview branch from ddc072a to 56fd95c Compare July 18, 2019 14:30

openshift-ci-robot assigned jtomasek Jul 18, 2019

openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 18, 2019

spadgett added this to the v4.2 milestone Jul 18, 2019

rawagner force-pushed the host-overview branch from 56fd95c to 006866c Compare July 19, 2019 19:20

openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 19, 2019

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 22, 2019

rawagner force-pushed the host-overview branch from 006866c to f49e00c Compare July 22, 2019 04:42

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2019

Add Baremetal hosts to overview dashboard inventory

82724b0

rawagner force-pushed the host-overview branch from f49e00c to 82724b0 Compare July 22, 2019 08:02

openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 22, 2019

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 22, 2019

openshift-ci-robot assigned atiratree Jul 22, 2019

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2019

openshift-merge-robot merged commit 0084ea6 into openshift:master Jul 22, 2019

	const hostMultiStatus = getHostStatus({ host: bmh, nodeMaintenance });
	const hostMultiStatus = getHostStatus({ host, nodeMaintenance });

Add Baremetal hosts to overview dashboard inventory #2069

Add Baremetal hosts to overview dashboard inventory #2069

Uh oh!

Conversation

rawagner commented Jul 17, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rawagner commented Jul 18, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jtomasek left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rawagner commented Jul 18, 2019

Uh oh!

jtomasek commented Jul 18, 2019

Uh oh!

openshift-bot commented Jul 18, 2019

Uh oh!

spadgett commented Jul 18, 2019

Uh oh!

spadgett commented Jul 18, 2019

Uh oh!

spadgett commented Jul 18, 2019

Uh oh!

spadgett commented Jul 18, 2019

Uh oh!

rawagner commented Jul 18, 2019

Uh oh!

rawagner commented Jul 19, 2019

Uh oh!

openshift-bot commented Jul 19, 2019

Uh oh!

openshift-bot commented Jul 19, 2019

Uh oh!

openshift-bot commented Jul 21, 2019

Uh oh!

openshift-bot commented Jul 21, 2019

Uh oh!

spadgett commented Jul 21, 2019

Uh oh!

rawagner commented Jul 21, 2019

Uh oh!

openshift-bot commented Jul 21, 2019

Uh oh!

openshift-bot commented Jul 21, 2019

Uh oh!

openshift-bot commented Jul 21, 2019

Uh oh!

openshift-bot commented Jul 21, 2019

Uh oh!

openshift-bot commented Jul 21, 2019

Uh oh!

openshift-bot commented Jul 21, 2019

Uh oh!

openshift-bot commented Jul 21, 2019

Uh oh!

openshift-bot commented Jul 22, 2019

Uh oh!

openshift-bot commented Jul 22, 2019

Uh oh!

rawagner commented Jul 17, 2019 •

edited

Loading

rawagner commented Jul 22, 2019 •

edited

Loading