Skip to content

Added PVC volume type info for volume information on workloads #2105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
anmolsachan wants to merge 2 commits into from
Closed

Added PVC volume type info for volume information on workloads #2105

anmolsachan wants to merge 2 commits into from

Conversation

@anmolsachan
Copy link
Contributor

@anmolsachan anmolsachan commented Jul 19, 2019 •
edited
Loading

Required change :

Added volume type information(PVC) for volumes attached to workloads.

Before:
Screenshot from 2019-07-19 22-20-23

After:
Screenshot from 2019-07-19 22-26-57

Dependency PR : #1891

zherman0 and others added 2 commits July 17, 2019 16:12
@zherman0
Remove Volume feature
1f3d57a
@anmolsachan
Added PVC volume type info on workloads
26d2dc3 
Signed-off-by: Anmol Sachan <anmol13694@gmail.com>
@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 19, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 19, 2019

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: anmolsachan
To complete the pull request process, please assign spadgett
You can assign the PR to them by writing /assign @spadgett in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@anmolsachan
Copy link
Contributor Author

anmolsachan commented Jul 19, 2019

@spadgett Please Review

@anmolsachan
Copy link
Contributor Author

anmolsachan commented Jul 19, 2019

/assign @spadgett

@spadgett
Copy link
Member

spadgett commented Jul 19, 2019 •
edited
Loading

/hold

This is a bug fix if nothing is showing up in the table, but imo it's not the right approach. We should have a link to the PVC/Secret/ConfigMap with the badge icon. See discussion in #1344

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 19, 2019
@spadgett
Copy link
Member

spadgett commented Jul 19, 2019

@anmolsachan I opened #2107 with the changes I had in mind

@anmolsachan
Copy link
Contributor Author

anmolsachan commented Jul 19, 2019

@anmolsachan I opened #2107 with the changes I had in mind

@spadgett Works for me. Closing this. Your PR looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TheRealJon TheRealJon Awaiting requested review from TheRealJon

@zherman0 zherman0 Awaiting requested review from zherman0

Assignees

@spadgett spadgett

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@anmolsachan @openshift-ci-robot @spadgett @zherman0