Fix bug where timeline border appeared when empty #22
+6
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/XS
rhamilto
force-pushed
the
timeline-empty-bug
branch
from
4b479e6 to
16fc6b8
Compare
openshift-ci-robot
added
size/S
christianvogt
pushed a commit
to christianvogt/console
that referenced
this pull request
Apr 8, 2019
…openshift#22) * Created mega-menu nav comp and added it in persepective switcher comp * Added changes according to the review comments * Added types for function components * Created new page layout and added backdrop on page section * Created mega-menu nav comp and added it in persepective switcher comp * Added changes according to the review comments * Added types for function components * Created new page layout and added backdrop on page section * fixed conflicts * Added changes according to the review comments * made changes according to review * Incorporating review comments * Updated styles of the Nav Toggle icon * added changes according to review * added unit tests * Incorporating review comments * added unit tests * Added Unit tests for outside click functionality * Add @type/jest, update node-sass package and tsconfig.json * Fix lint errors (#2) * Fix lint errors
christianvogt
pushed a commit
to christianvogt/console
that referenced
this pull request
May 7, 2019
…openshift#22) * Created mega-menu nav comp and added it in persepective switcher comp * Added changes according to the review comments * Added types for function components * Created new page layout and added backdrop on page section * Created mega-menu nav comp and added it in persepective switcher comp * Added changes according to the review comments * Added types for function components * Created new page layout and added backdrop on page section * fixed conflicts * Added changes according to the review comments * made changes according to review * Incorporating review comments * Updated styles of the Nav Toggle icon * added changes according to review * added unit tests * Incorporating review comments * added unit tests * Added Unit tests for outside click functionality * Add @type/jest, update node-sass package and tsconfig.json * Fix lint errors (#2) * Fix lint errors
TimothyAsirJeyasing
pushed a commit
to TimothyAsirJeyasing/console
that referenced
this pull request
Aug 3, 2022
Fix the dockerfile errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I introduced this regression in https://github.com/openshift/console/pull/11/files. SMH
Before:
After:
