Skip to content

[Bug#RHSTOR-532] name of the resource is variable entity#2206

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
cloudbehl:details-card-name-bug
Jul 30, 2019
Merged

[Bug#RHSTOR-532] name of the resource is variable entity#2206
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
cloudbehl:details-card-name-bug

Conversation

@cloudbehl
Copy link
Copy Markdown
Contributor

@cloudbehl cloudbehl commented Jul 29, 2019

  • Each namespace has one rook cluster so assuming that
    this fix has been done

Signed-off-by: Ankush Behl cloudbehl@gmail.com

@cloudbehl
Copy link
Copy Markdown
Contributor Author

cloudbehl commented Jul 29, 2019

/kind bug

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Jul 29, 2019

Hi @cloudbehl. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. kind/bug Categorizes issue or PR as related to a bug. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 29, 2019
@cloudbehl
Copy link
Copy Markdown
Contributor Author

cloudbehl commented Jul 29, 2019

/ok-to-test

@openshift-ci-robot openshift-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 29, 2019
@rawagner
Copy link
Copy Markdown
Contributor

rawagner commented Jul 30, 2019

you should also change type of cephClusterData which is now K8sResourceKind[]

@openshift-ci-robot openshift-ci-robot added the component/ceph Related to ceph-storage-plugin label Jul 30, 2019
@cloudbehl
[Bug#RHSTOR-532] name of the resource is variable entity
416be3a 
- Each namespace has one rook cluster so assuming that
  this fix has been done

Signed-off-by: Ankush Behl <cloudbehl@gmail.com>

Made type of cephCluster as k8s list
@cloudbehl cloudbehl force-pushed the details-card-name-bug branch from 6bfde7f to 416be3a Compare July 30, 2019 07:43
@rawagner
Copy link
Copy Markdown
Contributor

rawagner commented Jul 30, 2019

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2019
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Jul 30, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cloudbehl, rawagner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2019
@openshift-merge-robot openshift-merge-robot merged commit f5b0b08 into openshift:master Jul 30, 2019
@spadgett spadgett added this to the v4.2 milestone Jul 30, 2019
@e-minguez e-minguez mentioned this pull request Jul 30, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mareklibra mareklibra Awaiting requested review from mareklibra

@rawagner rawagner Awaiting requested review from rawagner

Assignees

@rawagner rawagner

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/ceph Related to ceph-storage-plugin kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

v4.2

Development

Successfully merging this pull request may close these issues.

5 participants

@cloudbehl @openshift-ci-robot @rawagner @spadgett @openshift-merge-robot