Skip to content

Remove orphaned react-lightweight-tooltip dependency and component #2455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 2 commits into from
Aug 28, 2019
Merged

Remove orphaned react-lightweight-tooltip dependency and component #2455

openshift-merge-robot merged 2 commits into from
Aug 28, 2019

Conversation

@rhamilto
Copy link
Member

@rhamilto rhamilto commented Aug 22, 2019 •
edited
Loading

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. component/core Related to console core functionality component/dev-console Related to dev-console size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 22, 2019
@rhamilto
Copy link
Member Author

rhamilto commented Aug 22, 2019

Replaces #2415 which I inadvertently munged and closed.

@spadgett spadgett mentioned this pull request Aug 22, 2019
Merged
@christianvogt
Copy link
Contributor

christianvogt commented Aug 26, 2019

@rhamilto I've confirmed that the changes to PipelineBars work as expected.
image

@rhamilto rhamilto changed the title [WIP] Remove orphaned react-lightweight-tooltip dependency and component Remove orphaned react-lightweight-tooltip dependency and component Aug 27, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 27, 2019
@rhamilto
Copy link
Member Author

rhamilto commented Aug 27, 2019

@spadgett, PTAL. Thank you, @christianvogt, for testing the change to PipelineBars.

@christianvogt
Copy link
Contributor

christianvogt commented Aug 27, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 27, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 27, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 28, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 28, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Aug 28, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 9d9d528 into openshift:master Aug 28, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Aug 28, 2019

@rhamilto: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws-console-olm 2f5ba9f link /test e2e-aws-console-olm

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@spadgett spadgett added this to the v4.2 milestone Aug 29, 2019
@rhamilto rhamilto deleted the remove-rlt branch November 13, 2019 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhadvig jhadvig Awaiting requested review from jhadvig

@rohitkrai03 rohitkrai03 Awaiting requested review from rohitkrai03

Assignees

@spadgett spadgett

@christianvogt christianvogt

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dev-console Related to dev-console lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

v4.2

Development

Successfully merging this pull request may close these issues.

6 participants

@rhamilto @christianvogt @openshift-ci-robot @openshift-bot @spadgett @openshift-merge-robot