Expose cdrom in UI - Story #1, #2, #3, #4

[glekner]

This PR implements a CDRom interface which includes a detail view of the CDRoms state, and a Modal to edit them.

[openshift-ci-robot]

Hi @glekner. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[matthewcarleton]

@glekner looking good so far. Will this PR cover editing as well?

[glekner]

@glekner looking good so far. Will this PR cover editing as well?

What do you mean by editing? I have some questions about the form validations maybe you can @ me at slack or chat

[glekner]

• Changed CSS @matthewcarleton (removed side paddings)
• Fixed new ModalFooter disabled prop and added inProgress prop
• Uses new ModalFooter now

[glekner]

• Reverted factory/modal changes

[matthewcarleton]

can you explain this why this is required?

[matthewcarleton]

I'm still not sure why we need custom classes for these. We could use pf-l-grid with pf-m-gutter. Maybe we can talk further about this if that's helpful.

[glekner]

• Updated VM Templates to support the new CD interface
• Updated CSS Grid layout

@mareklibra @matthewcarleton I added a button to the VM-Disks view to help create/edit CDs please approve.

[matthewcarleton]

• Updated VM Templates to support the new CD interface
• Updated CSS Grid layout

@mareklibra @matthewcarleton I added a button to the VM-Disks view to help create/edit CDs please approve.

Thanks for adding this @glekner a couple of comments:

• I'm not sure we want to have a specific action here for cd-roms. IMO it opens up a larger discussion about all the different type of disks that could exist here and having specific actions for each.
• I think we need a separate design effort to determine how CD-ROMs are edited via the disks tab so we can consider the larger issue of editing in general here.
• We also wouldn't want to have more than one primary action here.

Interested in @jelkosz opinion here as well.

[glekner]

@matthewcarleton Since the table now also shows the type (which can be cdrom), thought we need a way to edit it.
I also edited the Edit button in the kebab menu for each Disk, so if its a cdrom it will open the new Modal. So I can remove the new Pimary action.

[jelkosz]

@glekner we need to be consistent. If all the other disks are being edited using the edit from the row in which they are in, we need to open it from there. I would certainly remove the "Edit CD-ROMs button" from here.

[openshift-ci-robot]

@glekner: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws-console	0e0de587da7a7d98bf976f4ec689f9a0e641f8b0	link	/test e2e-aws-console
ci/prow/e2e-gcp	7a615a93dcc4668660e3a9fd24a1a045d3941696	link	/test e2e-gcp
ci/prow/e2e-aws-console-olm	afdac9c9306c562588020348dde8fdc8491b5a57	link	/test e2e-aws-console-olm

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[mareklibra]

@glekner , Please run linter with --fix
otherwise lgtm

[mareklibra]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: glekner, mareklibra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• frontend/packages/kubevirt-plugin/OWNERS [mareklibra]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment