Skip to content

kubevirt: Add VM Dashboard Inventory Card #2751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Oct 2, 2019
Merged

kubevirt: Add VM Dashboard Inventory Card #2751

openshift-merge-robot merged 1 commit into from
Oct 2, 2019

Conversation

@mareklibra
Copy link
Contributor

@mareklibra mareklibra commented Sep 18, 2019 •
edited
Loading

On the VM Details Overview tab.

Depends on:

Just the last commit is relevant.

@openshift-ci-robot openshift-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 18, 2019
@openshift-ci-robot openshift-ci-robot added component/core Related to console core functionality component/kubevirt Related to kubevirt-plugin component/metal3 Related to metal3-plugin component/sdk Related to console-plugin-sdk component/shared Related to console-shared labels Sep 18, 2019
@mareklibra
Copy link
Contributor Author

mareklibra commented Sep 18, 2019

vmInventory

@mareklibra
Copy link
Contributor Author

mareklibra commented Sep 18, 2019

cc @andybraren

@mareklibra
Copy link
Contributor Author

mareklibra commented Sep 18, 2019

/retest

@mareklibra mareklibra changed the base branch from master to master-4.3 September 19, 2019 11:36
@mareklibra
Copy link
Contributor Author

mareklibra commented Sep 19, 2019

Rebased to master-4.3

@rawagner, can you please have a look?

@openshift-ci-robot openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. component/dashboard Related to dashboard labels Sep 25, 2019
@spadgett spadgett changed the base branch from master-4.3 to master September 26, 2019 14:37
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 30, 2019
@mareklibra
Copy link
Contributor Author

mareklibra commented Sep 30, 2019

Rebased as #2600 is merged.

rawagner
rawagner suggested changes Sep 30, 2019
View reviewed changes
Copy link
Contributor

@rawagner rawagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one comment, otherwise lgtm

frontend/packages/kubevirt-plugin/src/selectors/vmi/selectors.ts Outdated
@@ -10,3 +11,6 @@ export const getVMIApiPath = (vmi: VMIKind) =>
`${VirtualMachineInstanceModel.apiVersion}/namespaces/${getNamespace(vmi)}/${
VirtualMachineInstanceModel.plural
}/${getName(vmi)}`;

export const getVMINetworks = (vmi: VMIKind) => _.get(vmi, 'spec.networks', []);
Copy link
Contributor

@rawagner rawagner Sep 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add return type ie VMIKind['spec]['networks'], same for getVMIDisks

Copy link
Contributor Author

@mareklibra mareklibra Oct 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per discussion in other PR, I have replaced the _.get() by direct access.

Copy link
Contributor

@rawagner rawagner Oct 1, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 1, 2019
@mareklibra
Copy link
Contributor Author

mareklibra commented Oct 1, 2019

Rebased, #2601 is merged now

@rawagner
Copy link
Contributor

rawagner commented Oct 1, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2019
@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 1, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 1, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@rawagner
Copy link
Contributor

rawagner commented Oct 1, 2019

tests are failing

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 1, 2019
@mareklibra
kubevirt: Add VM Dashboard Inventory Card
fec1969 
On the VM Details Overview tab.
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 2, 2019
@mareklibra
Copy link
Contributor Author

mareklibra commented Oct 2, 2019

/retest

@rawagner
Copy link
Contributor

rawagner commented Oct 2, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 2, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 2, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mareklibra, rawagner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rawagner
Copy link
Contributor

rawagner commented Oct 2, 2019

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 2, 2019
@openshift-merge-robot openshift-merge-robot merged commit 62a6431 into openshift:master Oct 2, 2019
@spadgett spadgett added this to the v4.3 milestone Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christianvogt christianvogt Awaiting requested review from christianvogt

@flofuchs flofuchs Awaiting requested review from flofuchs

1 more reviewer

@rawagner rawagner rawagner requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rawagner rawagner

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dashboard Related to dashboard component/kubevirt Related to kubevirt-plugin component/metal3 Related to metal3-plugin component/sdk Related to console-plugin-sdk component/shared Related to console-shared lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

v4.3

Development

Successfully merging this pull request may close these issues.

6 participants

@mareklibra @rawagner @openshift-bot @openshift-ci-robot @spadgett @openshift-merge-robot