Skip to content

console-shared: add pod selectors for volumes and containers #2832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Oct 6, 2019
Merged

console-shared: add pod selectors for volumes and containers #2832

openshift-merge-robot merged 1 commit into from
Oct 6, 2019

Conversation

@mareklibra
Copy link
Contributor

@mareklibra mareklibra commented Sep 25, 2019 •
edited
Loading

Depends on:

Just last commit is relevant.

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. component/core Related to console core functionality component/kubevirt Related to kubevirt-plugin component/shared Related to console-shared labels Sep 25, 2019
@spadgett spadgett changed the base branch from master-4.3 to master September 25, 2019 20:07
spadgett
spadgett reviewed Sep 25, 2019
View reviewed changes
@spadgett
Copy link
Member

spadgett commented Sep 25, 2019

/hold

These selectors are an anti-pattern imo. We should be trying to remove them instead of adding more.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 25, 2019
@spadgett
Copy link
Member

spadgett commented Sep 26, 2019

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 26, 2019
@mareklibra mareklibra mentioned this pull request Sep 27, 2019
Closed
3 tasks
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 30, 2019
@mareklibra
Copy link
Contributor Author

mareklibra commented Sep 30, 2019

Rebased and changed to avoid lodash.get().

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 2, 2019
@mareklibra
Copy link
Contributor Author

mareklibra commented Oct 2, 2019

Rebased as #2809 is merged now.
@vojtechszocs , can you please have a look?

@mareklibra
Copy link
Contributor Author

mareklibra commented Oct 2, 2019

/retest

@vojtechszocs
Copy link
Contributor

vojtechszocs commented Oct 2, 2019

/lgtm

FYI, there's a TC39 proposal Optional Chaining for JavaScript that would allow us to do:

-const foo = a && a.b && a.b.c;
+const foo = a?.b?.c;

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 2, 2019
@spadgett
Copy link
Member

spadgett commented Oct 2, 2019

/lgtm

FYI, there's a TC39 proposal Optional Chaining for JavaScript that would allow us to do:

-const foo = a && a.b && a.b.c;
+const foo = a?.b?.c;

Yeah, @christianvogt pointed out this is in the TypeScript 3.7 beta: https://devblogs.microsoft.com/typescript/announcing-typescript-3-7-beta/

@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 4, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 4, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 4, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 4, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 4, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 4, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 4, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 4, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 4, 2019
@mareklibra
Copy link
Contributor Author

mareklibra commented Oct 4, 2019

Rebased

@vojtechszocs
Copy link
Contributor

vojtechszocs commented Oct 4, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 4, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Oct 4, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mareklibra, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

openshift-bot commented Oct 6, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 8063c08 into openshift:master Oct 6, 2019
@spadgett spadgett added this to the v4.3 milestone Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spadgett spadgett spadgett left review comments

@dtaylor113 dtaylor113 Awaiting requested review from dtaylor113

@pcbailey pcbailey Awaiting requested review from pcbailey

Assignees

@vojtechszocs vojtechszocs

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/kubevirt Related to kubevirt-plugin component/shared Related to console-shared lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v4.3

Development

Successfully merging this pull request may close these issues.

6 participants

@mareklibra @spadgett @vojtechszocs @openshift-bot @openshift-ci-robot @openshift-merge-robot