Fix cli-download link by changing "text" to "name"

[benjaminapetersen]

While experimenting with options for openshift/console-operator#301, I came across this bug:

Before:

After:

Simple swap in of .name for .text.

/assign @rhamilto @jhadvig

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benjaminapetersen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• frontend/OWNERS [benjaminapetersen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rhamilto]

This change:

1. isn't backward compatible
2. orphans the text property

Why not simply put name in text?

[spadgett]

/hold

[spadgett]

I think it's the operator PR that's wrong. The property in openshift/api uses text.

https://github.com/openshift/api/blob/3ca714bc5b1b13c4e9381147d9994c0384b20e23/console/v1/types.go#L5-L6

[spadgett]

CRD also has text: https://github.com/openshift/console-operator/blob/master/manifests/00-crd-extension-console-link.yaml#L46-L48

[benjaminapetersen]

Ah, correct, per https://github.com/openshift/api/blob/master/console/v1/types.go#L6

type Link struct {
	// text is the display text for the link
	Text string `json:"text"`
	// href is the absolute secure URL for the link (must use https)
	Href string `json:"href"`
}

Text is the correct field. Migration to cluster-config-operator just merged, with the fields generated from openshift/api, though text was the field in the console-operator.

[benjaminapetersen]

Ah, mistake because unknown fields are not pruned, I think thats what got me :)