Hide linux bridge option if HCO is not installed #3183
Conversation
openshift-ci-robot
added
size/M
...ugin/src/components/network-attachment-definitions/NetworkAttachmentDefinitionCreateYaml.tsx
Outdated
Show resolved
Hide resolved
...on-plugin/src/components/network-attachment-definitions/NetworkAttachmentDefinitionsForm.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
why changing this to any ?
There was a problem hiding this comment.
The NetworkAttachmentDefinitionConfig type didn't really fit anymore. I added more specific types. I'm planning on a follow-up to increase the type support throughout the plugin, as well.
There was a problem hiding this comment.
please create enum out of these keys so you dont have to use strings in the rest of the code
...on-plugin/src/components/network-attachment-definitions/NetworkAttachmentDefinitionsForm.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
dont we want to create model for HyperConverged CRD ?
There was a problem hiding this comment.
We're not actually using the HyperConverged CRD aside from testing that it exists, so I wasn't sure if I should create one. I went ahead and made it. It's easy enough to remove if we decide it's unnecessary.
pcbailey
force-pushed
the
hide-linux-bridge-if-hco-not-installed
branch
from
ad28334 to
2bc7c67
Compare
openshift-ci-robot
added
size/L
pcbailey
force-pushed
the
hide-linux-bridge-if-hco-not-installed
branch
from
2bc7c67 to
d840b65
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pcbailey, rawagner The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
5 participants
This PR hides the "Linux bridge" Network Type option in the network attachment definitions creation form if the HyperConverged Cluster Operator isn't installed. It also disables the Network Type dropdown if no types are available.
@phoracek