Skip to content

Update the network attachment definition YAML template #3193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Nov 13, 2019
Merged

Update the network attachment definition YAML template #3193

openshift-merge-robot merged 1 commit into from
Nov 13, 2019

Conversation

@pcbailey
Copy link
Contributor

@pcbailey pcbailey commented Nov 1, 2019

This PR updates the network attachment definition YAML template. An example is below.

apiVersion: k8s.cni.cncf.io/v1
kind: NetworkAttachmentDefinition
metadata:
  name: example
  namespace: test-project
spec:
  config: '{}'

@phoracek

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 1, 2019
@pcbailey pcbailey mentioned this pull request Nov 3, 2019
Closed
@pcbailey pcbailey force-pushed the update-network-attachment-definition-yaml-template branch from 4fc993c to e12a058 Compare November 11, 2019 13:57
@rawagner
Copy link
Contributor

rawagner commented Nov 11, 2019

/lgtm

@rawagner
Copy link
Contributor

rawagner commented Nov 11, 2019

/lgtm

@pcbailey
Copy link
Contributor Author

pcbailey commented Nov 11, 2019

/retest

1 similar comment
@mareklibra
Copy link
Contributor

mareklibra commented Nov 13, 2019

/retest

@rawagner
Copy link
Contributor

rawagner commented Nov 13, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 13, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pcbailey, phoracek, rawagner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit b58fb78 into openshift:master Nov 13, 2019
@spadgett spadgett added this to the v4.3 milestone Nov 19, 2019
@pcbailey pcbailey deleted the update-network-attachment-definition-yaml-template branch October 26, 2022 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mareklibra mareklibra Awaiting requested review from mareklibra

@rawagner rawagner Awaiting requested review from rawagner

1 more reviewer

@phoracek phoracek phoracek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rawagner rawagner

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

v4.3

Development

Successfully merging this pull request may close these issues.

7 participants

@pcbailey @rawagner @mareklibra @openshift-ci-robot @phoracek @spadgett @openshift-merge-robot