Bug 1745431: Birthday attack against 64-bit block ciphers (with library-go)

[benjaminapetersen]

Alternative to #3389
Import library-go to get crypto.DefaultCiphers()

copied description from above PR:

Update tls.Config with DefaultCiphers() from library-go.

library-go file:
https://github.com/openshift/library-go/blob/11013d437d762f00827c7e80d18b0a7b0abc07bd/pkg/crypto/crypto.go#L242

Note that Bug 1745431 is for 3.11, but I assume we want to apply to current console & backport?

/assign @spadgett

TODO: test to verify

[openshift-ci-robot]

@benjaminapetersen: This pull request references Bugzilla bug 1745431, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Bug 1745431: Birthday attack against 64-bit block ciphers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benjaminapetersen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [benjaminapetersen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@benjaminapetersen: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/prow/images	37be883	link	/test images
ci/prow/e2e-gcp-console	37be883	link	/test e2e-gcp-console
ci/prow/analyze	37be883	link	/test analyze
ci/prow/frontend	37be883	link	/test frontend
ci/prow/backend	37be883	link	/test backend

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[benjaminapetersen]

Closing this, I think we favor the other PR.