Bug 1773788: Birthday attack against 64-bit block ciphers [Release-4.1.z] #3693

benjaminapetersen · 2019-12-05T20:08:12Z

A manual backport of #3389 due to a few conflicts with an attempt at an automatic cherry-pick.

add bash script to test a sample of good ciphers & bad ciphers
fixes CVE SSL/TLS: Birthday attack against 64-bit block ciphers (SWEET32)

openshift-ci-robot · 2019-12-05T20:08:18Z

@benjaminapetersen: This pull request references Bugzilla bug 1773788, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Bug 1773788: Birthday attack against 64-bit block ciphers [OpenShift 4.1.z]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

benjaminapetersen · 2019-12-05T20:08:24Z

/assign @spadgett

benjaminapetersen · 2019-12-05T20:08:58Z

/cherry-pick release-3.11

For bug https://bugzilla.redhat.com/show_bug.cgi?id=1745431
I believe this commit will pick cleanly back at this point.

openshift-cherrypick-robot · 2019-12-05T20:08:59Z

@benjaminapetersen: once the present PR merges, I will cherry-pick it on top of release-3.11 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-3.11

I believe this commit will pick cleanly back at this point.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

spadgett

/lgtm

openshift-bot · 2019-12-05T20:26:27Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-05T20:40:03Z

/retest

Please review the full test history for this PR and help us cut down flakes.

benjaminapetersen · 2019-12-05T20:47:43Z

Hmm. Goland autoformat missed main.go.
@spadgett care to tag one more time?

spadgett

/lgtm

benjaminapetersen · 2019-12-05T21:45:40Z

/retest

template pod "e2e-aws-console-olm" failed: the pod ci-op-6v2fdxf1/e2e-aws-console-olm failed after 39m52s (failed containers: test): ContainerFailed one or more containers exited

openshift-bot · 2019-12-05T23:53:11Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-06T00:06:30Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-06T00:58:31Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-06T01:11:32Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-06T05:05:26Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-06T05:18:26Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-06T06:10:24Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-06T07:02:31Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-06T07:15:35Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-07T15:57:58Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-07T16:10:42Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-07T16:49:42Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-07T17:02:42Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-07T17:41:41Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-07T17:54:41Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-07T18:33:42Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-07T18:59:43Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-07T19:25:42Z

/retest

Please review the full test history for this PR and help us cut down flakes.

shawn-hurley · 2019-12-07T19:41:36Z

/hold

it has 48 times, let's give it a break over the weekend

spadgett · 2019-12-08T18:01:00Z

./test-prow-e2e.sh: line 29: ./test-ciphers.sh: Permission denied

@benjaminapetersen looks like the new script is not executable

/lgtm cancel
/hold cancel

- add bash script to test a sample of good ciphers & bad ciphers - fixes CVE SSL/TLS: Birthday attack against 64-bit block ciphers (SWEET32)

benjaminapetersen · 2019-12-09T15:46:53Z

chmod +x test-ciphers.sh

Lets see if we run now.

benjaminapetersen · 2019-12-09T17:56:19Z

@spadgett looks like we are good here for a new lgtm.

benjaminapetersen · 2019-12-09T17:57:25Z

@shawn-hurley sorry about that, 48 runs is prob more than enough to say "its broken" 😄 It would be handy if there was a limit on the bot eh?

benjaminapetersen · 2019-12-10T15:58:51Z

@spadgett just for a fresh lgtm.

spadgett

/lgtm

spadgett · 2019-12-11T19:43:32Z

/lgtm cancel
4.3 fix failed validation

openshift-ci-robot · 2019-12-11T19:43:56Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benjaminapetersen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [benjaminapetersen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

benjaminapetersen · 2019-12-19T15:21:09Z

/hold

incomplete.

openshift-ci-robot · 2020-07-16T18:21:04Z

@benjaminapetersen: This pull request references Bugzilla bug 1773788. The bug has been updated to no longer refer to the pull request using the external bug tracker.

Details

In response to this:

Bug 1773788: Birthday attack against 64-bit block ciphers [Release-4.1.z]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Dec 5, 2019

openshift-ci-robot assigned spadgett Dec 5, 2019

openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 5, 2019

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2019

openshift-ci-robot requested review from jhadvig and rhamilto December 5, 2019 20:09

spadgett approved these changes Dec 5, 2019

View reviewed changes

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2019

spadgett added this to the v4.1.z milestone Dec 5, 2019

benjaminapetersen force-pushed the backport/release-4.1/bug/1773788/birthday-attack-against-64-bit-block-ciphers branch from fef869b to c78df3e Compare December 5, 2019 20:47

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2019

spadgett approved these changes Dec 5, 2019

View reviewed changes

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 5, 2019

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 7, 2019

openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Dec 8, 2019

Update tls.Config with DefaultCiphers() from library-go

a5ad972

- add bash script to test a sample of good ciphers & bad ciphers - fixes CVE SSL/TLS: Birthday attack against 64-bit block ciphers (SWEET32)

benjaminapetersen force-pushed the backport/release-4.1/bug/1773788/birthday-attack-against-64-bit-block-ciphers branch from c78df3e to a5ad972 Compare December 9, 2019 15:46

spadgett approved these changes Dec 10, 2019

View reviewed changes

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 10, 2019

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Dec 11, 2019

benjaminapetersen changed the title ~~Bug 1773788: Birthday attack against 64-bit block ciphers [OpenShift 4.1.z]~~ Bug 1773788: Birthday attack against 64-bit block ciphers [Release-4.1.z] Dec 16, 2019

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 19, 2019

spadgett closed this Jul 16, 2020

Bug 1773788: Birthday attack against 64-bit block ciphers [Release-4.1.z] #3693

Bug 1773788: Birthday attack against 64-bit block ciphers [Release-4.1.z] #3693

Uh oh!

Conversation

benjaminapetersen commented Dec 5, 2019

Uh oh!

openshift-ci-robot commented Dec 5, 2019

Uh oh!

benjaminapetersen commented Dec 5, 2019

Uh oh!

benjaminapetersen commented Dec 5, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-cherrypick-robot commented Dec 5, 2019

Uh oh!

spadgett left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-bot commented Dec 5, 2019

Uh oh!

openshift-bot commented Dec 5, 2019

Uh oh!

benjaminapetersen commented Dec 5, 2019

Uh oh!

spadgett left a comment

Choose a reason for hiding this comment

Uh oh!

benjaminapetersen commented Dec 5, 2019

Uh oh!

openshift-bot commented Dec 5, 2019

Uh oh!

openshift-bot commented Dec 6, 2019

Uh oh!

openshift-bot commented Dec 6, 2019

Uh oh!

openshift-bot commented Dec 6, 2019

Uh oh!

openshift-bot commented Dec 6, 2019

Uh oh!

openshift-bot commented Dec 6, 2019

Uh oh!

openshift-bot commented Dec 6, 2019

Uh oh!

openshift-bot commented Dec 6, 2019

Uh oh!

openshift-bot commented Dec 6, 2019

Uh oh!

openshift-bot commented Dec 7, 2019

Uh oh!

openshift-bot commented Dec 7, 2019

Uh oh!

openshift-bot commented Dec 7, 2019

Uh oh!

openshift-bot commented Dec 7, 2019

Uh oh!

openshift-bot commented Dec 7, 2019

Uh oh!

openshift-bot commented Dec 7, 2019

Uh oh!

openshift-bot commented Dec 7, 2019

Uh oh!

openshift-bot commented Dec 7, 2019

Uh oh!

openshift-bot commented Dec 7, 2019

Uh oh!

shawn-hurley commented Dec 7, 2019

Uh oh!

spadgett commented Dec 8, 2019

Uh oh!

benjaminapetersen commented Dec 9, 2019

Uh oh!

benjaminapetersen commented Dec 9, 2019

Uh oh!

benjaminapetersen commented Dec 9, 2019

Uh oh!

benjaminapetersen commented Dec 10, 2019

Uh oh!

spadgett left a comment

Choose a reason for hiding this comment

Uh oh!

benjaminapetersen commented Dec 5, 2019 •

edited

Loading