Skip to content

updates test and refactors component for RevisionsOverviewList #3752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jan 3, 2020
Merged

updates test and refactors component for RevisionsOverviewList #3752

openshift-merge-robot merged 1 commit into from
Jan 3, 2020

Conversation

@invincibleJai
Copy link
Member

@invincibleJai invincibleJai commented Dec 11, 2019

updates test and refactors component for RevisionsOverviewList

  • Refactored RevisionsOverviewList into two component RevisionsOverviewListItem and RevisionsOverviewList
  • Added unit tests for RevisionsOverviewList
  • Added unit tests for RevisionsOverviewListItem

Tracks: https://jira.coreos.com/browse/ODC-2513

Screenshot

Screenshot 2019-12-11 at 5 42 21 PM

@openshift-ci-robot openshift-ci-robot added component/knative Related to knative-plugin size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 11, 2019
vikram-raj
vikram-raj reviewed Dec 12, 2019
View reviewed changes
frontend/packages/knative-plugin/src/components/overview/RevisionsOverviewListItem.scss Outdated
Copy link
Member

@vikram-raj vikram-raj Dec 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
padding: 15px 15px 0px 20px;
padding: 15px 20px 0;

Padding right and left: 20px, top: 15px; and bottom: 0;

@invincibleJai invincibleJai force-pushed the fix-add-unit-revoverviewlist branch from 0459989 to 856b162 Compare December 12, 2019 12:16
vikram-raj
vikram-raj reviewed Dec 12, 2019
View reviewed changes
Copy link
Member

@vikram-raj vikram-raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 12, 2019
rohitkrai03
rohitkrai03 approved these changes Dec 16, 2019
View reviewed changes
Copy link
Contributor

@rohitkrai03 rohitkrai03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 16, 2019
@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 16, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 16, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@invincibleJai
Copy link
Member Author

invincibleJai commented Dec 16, 2019

/test e2e-gcp-console

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 16, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 16, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 16, 2019
@invincibleJai invincibleJai force-pushed the fix-add-unit-revoverviewlist branch from 856b162 to 488b6cf Compare December 17, 2019 14:18
@openshift-ci-robot openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Dec 17, 2019
vikram-raj
vikram-raj reviewed Dec 17, 2019
View reviewed changes
Copy link
Member

@vikram-raj vikram-raj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 17, 2019
@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 17, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 17, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 17, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 17, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 17, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 17, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 18, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 18, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 21, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

11 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 21, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 21, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 21, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 21, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 21, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 21, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 21, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 21, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 21, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 21, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 21, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@spadgett
Copy link
Member

spadgett commented Dec 21, 2019

/hold
e2e-gcp-console is currently broken

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 21, 2019
@invincibleJai invincibleJai force-pushed the fix-add-unit-revoverviewlist branch from 6dbda84 to 204b252 Compare December 30, 2019 11:10
@openshift-ci-robot openshift-ci-robot added component/dev-console Related to dev-console and removed lgtm Indicates that a PR is ready to be merged. labels Dec 30, 2019
@invincibleJai
Copy link
Member Author

invincibleJai commented Dec 30, 2019

/cc @vikram-raj

@karthikjeeyar
Copy link
Contributor

karthikjeeyar commented Dec 30, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 30, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 30, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divyanshiGupta, invincibleJai, karthikjeeyar, rohitkrai03, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@invincibleJai invincibleJai mentioned this pull request Jan 2, 2020
Merged
@spadgett
Copy link
Member

spadgett commented Jan 2, 2020

/hold cancel
/retest
#3847 has fixed the e2e tests

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 2, 2020
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 9bd9789 into openshift:master Jan 3, 2020
@spadgett spadgett added this to the v4.4 milestone Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vikram-raj vikram-raj Awaiting requested review from vikram-raj

2 more reviewers

@divyanshiGupta divyanshiGupta divyanshiGupta left review comments

@rohitkrai03 rohitkrai03 rohitkrai03 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vikram-raj vikram-raj

@karthikjeeyar karthikjeeyar

@divyanshiGupta divyanshiGupta

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/dev-console Related to dev-console component/knative Related to knative-plugin lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

v4.4

Development

Successfully merging this pull request may close these issues.

9 participants

@invincibleJai @openshift-bot @divyanshiGupta @spadgett @karthikjeeyar @openshift-ci-robot @vikram-raj @rohitkrai03 @openshift-merge-robot