Skip to content

Update ESLint autoFixOnSave settings to the new code action format #3803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jan 3, 2020
Merged

Update ESLint autoFixOnSave settings to the new code action format #3803

openshift-merge-robot merged 1 commit into from
Jan 3, 2020

Conversation

@rhamilto
Copy link
Member

@rhamilto rhamilto commented Dec 18, 2019

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 18, 2019
@christianvogt
Copy link
Contributor

christianvogt commented Dec 18, 2019

@rhamilto shouldn't we remove this "eslint.autoFixOnSave": true, ?

@rhamilto
Copy link
Member Author

rhamilto commented Dec 18, 2019

@rhamilto shouldn't we remove this "eslint.autoFixOnSave": true, ?

Perhaps. I am unclear if that's needed for legacy support?

@rhamilto
Copy link
Member Author

rhamilto commented Dec 18, 2019

@rhamilto shouldn't we remove this "eslint.autoFixOnSave": true, ?

Perhaps. I am unclear if that's needed for legacy support?

Seems like we keep it? https://github.com/microsoft/vscode-eslint/blob/master/README.md#settings-conversion

benjaminapetersen
benjaminapetersen reviewed Dec 18, 2019
View reviewed changes
@rhamilto rhamilto force-pushed the update-vscode-config branch from 469fdbb to a0fa12b Compare December 18, 2019 21:13
@benjaminapetersen
Copy link
Contributor

benjaminapetersen commented Dec 18, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 18, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: benjaminapetersen, rhamilto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@benjaminapetersen benjaminapetersen mentioned this pull request Dec 18, 2019
Merged
@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 18, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 18, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 19, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 19, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 19, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 19, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 19, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 19, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@christianvogt
Copy link
Contributor

christianvogt commented Dec 19, 2019

I just thought that if it's deprecated and expect everyone to be updating. But i guess if it doesn't do harm keep it for now.

@benjaminapetersen
Copy link
Contributor

benjaminapetersen commented Dec 19, 2019

I didn't have a strong feeling since it was just the one item, but definitely wanted a comment. Long term we are probably better off keeping it tidy & removing legacy cruft.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 19, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 19, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 19, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 19, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 21, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

20 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 21, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 21, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 21, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 21, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 21, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 21, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 21, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 21, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 21, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 21, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 21, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 21, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 21, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 21, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 21, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 21, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 21, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 21, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 21, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 21, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@spadgett
Copy link
Member

spadgett commented Dec 21, 2019

/hold
e2e-gcp-console is currently broken

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 21, 2019
@rhamilto
Copy link
Member Author

rhamilto commented Jan 2, 2020

When I opened VSCode this morning, I got this modal. It answers the compatibility question.
Screen Shot 2020-01-02 at 9 06 11 AM

@spadgett
Copy link
Member

spadgett commented Jan 2, 2020

/hold cancel
/retest
#3847 has fixed the e2e tests

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 2, 2020
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 5dba41a into openshift:master Jan 3, 2020
@rhamilto rhamilto deleted the update-vscode-config branch January 3, 2020 13:49
@spadgett spadgett added this to the v4.4 milestone Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeff-phillips-18 jeff-phillips-18 Awaiting requested review from jeff-phillips-18

@kyoto kyoto Awaiting requested review from kyoto

1 more reviewer

@benjaminapetersen benjaminapetersen benjaminapetersen left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@benjaminapetersen benjaminapetersen

@christianvogt christianvogt

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v4.4

Development

Successfully merging this pull request may close these issues.

7 participants

@rhamilto @christianvogt @benjaminapetersen @openshift-ci-robot @openshift-bot @spadgett @openshift-merge-robot