Skip to content

Conversation

@afreen23
Copy link

@afreen23 afreen23 commented Dec 23, 2019

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1776855

Before:
Screenshot from 2019-12-27 16-35-46

After:
Screenshot from 2019-12-27 16-37-01

Co-authored-by: Kanika kmuraraka@redhat.com
Signed-off-by: Afreen Rahman afrahman@redhat.com

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Dec 23, 2019
@openshift-ci-robot
Copy link
Contributor

@afreen23: This pull request references Bugzilla bug 1776855, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Bug 1776855: Fixes negative values in capacity breakdown

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 23, 2019
@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. component/ceph Related to ceph-storage-plugin labels Dec 23, 2019
@afreen23
Copy link
Author

e2e-gcp-console is broken now.
Wait for fix to add lgtm

@openshift-ci-robot
Copy link
Contributor

@afreen23: This pull request references Bugzilla bug 1776855, which is valid.

Details

In response to this:

Bug 1776855: Fixes negative values in capacity breakdown

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1776855

Co-authored-by: Kanika <kmuraraka@redhat.com>
Signed-off-by: Afreen Rahman <afrahman@redhat.com>
@openshift-ci-robot
Copy link
Contributor

@afreen23: This pull request references Bugzilla bug 1776855, which is valid.

Details

In response to this:

Bug 1776855: Fixes negative values in capacity breakdown

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@openshift-ci-robot
Copy link
Contributor

@afreen23: This pull request references Bugzilla bug 1776855, which is valid.

Details

In response to this:

Bug 1776855: Fixes negative values in capacity breakdown

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@a2batic a2batic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 27, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a2batic, afreen23

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@afreen23
Copy link
Author

afreen23 commented Dec 27, 2019

/hold
as e2e tests are broken
#comment

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 27, 2019
@spadgett
Copy link
Member

spadgett commented Jan 2, 2020

/hold cancel
/retest
#3847 has fixed the e2e tests

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 2, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 8190844 into openshift:master Jan 3, 2020
@openshift-ci-robot
Copy link
Contributor

@afreen23: All pull requests linked via external trackers have merged. Bugzilla bug 1776855 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1776855: Fixes negative values in capacity breakdown

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@afreen23
Copy link
Author

afreen23 commented Jan 3, 2020

/cherrypick release-4.3

@openshift-cherrypick-robot

@afreen23: new pull request created: #3853

Details

In response to this:

/cherrypick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. component/ceph Related to ceph-storage-plugin lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants