Skip to content

refactor and added specs for OverviewDetailsKnativeResourcesTab #3828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jan 3, 2020
Merged

refactor and added specs for OverviewDetailsKnativeResourcesTab #3828

openshift-merge-robot merged 1 commit into from
Jan 3, 2020

Conversation

@invincibleJai
Copy link
Member

@invincibleJai invincibleJai commented Dec 24, 2019

refactor and added specs for OverviewDetailsKnativeResourcesTab

Tracks : https://issues.redhat.com/browse/ODC-2557

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. component/knative Related to knative-plugin labels Dec 24, 2019
vikram-raj
vikram-raj reviewed Dec 24, 2019
View reviewed changes
...knative-plugin/src/components/overview/__tests__/OverviewDetailsKnativeResourcesTab.spec.tsx Outdated
Copy link
Member

@vikram-raj vikram-raj Dec 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Define the props type using React.ComponentProps. Avoid importing the prop type in spec file.

Copy link
Member Author

@invincibleJai invincibleJai Dec 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@invincibleJai invincibleJai force-pushed the add-unit-overviewKnResTab branch from c42f18f to 9dbc63e Compare December 24, 2019 13:48
karthikjeeyar
karthikjeeyar reviewed Dec 26, 2019
View reviewed changes
...knative-plugin/src/components/overview/__tests__/OverviewDetailsKnativeResourcesTab.spec.tsx Outdated
Copy link
Contributor

@karthikjeeyar karthikjeeyar Dec 24, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be repetitive, can we combine all the properties and simply overwrite obj alone in each tests. WDYT?

Copy link
Member Author

@invincibleJai invincibleJai Dec 26, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@invincibleJai invincibleJai force-pushed the add-unit-overviewKnResTab branch from 9dbc63e to a25e9a4 Compare December 26, 2019 14:01
@invincibleJai invincibleJai force-pushed the add-unit-overviewKnResTab branch from a25e9a4 to 5f015fa Compare December 26, 2019 14:51
@karthikjeeyar
Copy link
Contributor

karthikjeeyar commented Dec 26, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 26, 2019
@invincibleJai
Copy link
Member Author

invincibleJai commented Dec 30, 2019

/assign @rohitkrai03 @andrewballantyne

rohitkrai03
rohitkrai03 approved these changes Dec 30, 2019
View reviewed changes
Copy link
Contributor

@rohitkrai03 rohitkrai03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 30, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: invincibleJai, karthikjeeyar, rohitkrai03

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 30, 2019
@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 30, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 30, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 30, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@andrewballantyne
Copy link
Contributor

andrewballantyne commented Dec 30, 2019

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 30, 2019
@andrewballantyne
Copy link
Contributor

andrewballantyne commented Jan 2, 2020

/hold cancel
/retest
#3847 has fixed the e2e tests

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 2, 2020
@openshift-merge-robot openshift-merge-robot merged commit fc408e5 into openshift:master Jan 3, 2020
@spadgett spadgett added this to the v4.4 milestone Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christianvogt christianvogt Awaiting requested review from christianvogt

3 more reviewers

@vikram-raj vikram-raj vikram-raj left review comments

@karthikjeeyar karthikjeeyar karthikjeeyar left review comments

@rohitkrai03 rohitkrai03 rohitkrai03 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@karthikjeeyar karthikjeeyar

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/knative Related to knative-plugin lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

v4.4

Development

Successfully merging this pull request may close these issues.

9 participants

@invincibleJai @karthikjeeyar @openshift-ci-robot @openshift-bot @andrewballantyne @vikram-raj @rohitkrai03 @spadgett @openshift-merge-robot