Skip to content

Add VMI link to VM detauls page #3840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 2 commits into from
Jan 3, 2020
Merged

Add VMI link to VM detauls page #3840

openshift-merge-robot merged 2 commits into from
Jan 3, 2020

Conversation

@yaacov
Copy link
Member

@yaacov yaacov commented Dec 31, 2019 •
edited
Loading

Add VMI link to VM detauls page

We decided to expose VMIs to users, this PR expose the the VMI in the VM details page.

Refs:
https://issues.redhat.com/browse/KNIP-1165
openshift/openshift-origin-design#310

vm cirros · Details · OKD

@yaacov
Add VMI link to VM detauls page
ee55124 
Signed-off-by: yaacov <kobi.zamir@gmail.com>
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 31, 2019
@openshift-ci-robot openshift-ci-robot added component/kubevirt Related to kubevirt-plugin approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 31, 2019
@yaacov
Copy link
Member Author

yaacov commented Dec 31, 2019

@irosenzw @glekner please review

cc:// @yfrimanm

@yaacov
Copy link
Member Author

yaacov commented Dec 31, 2019

/test analyze

2 similar comments
@yaacov
Copy link
Member Author

yaacov commented Dec 31, 2019

/test analyze

@yaacov
Copy link
Member Author

yaacov commented Dec 31, 2019

/test analyze

glekner
glekner suggested changes Jan 1, 2020
View reviewed changes
Copy link
Contributor

@glekner glekner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but a small comment

frontend/packages/kubevirt-plugin/src/components/vms/vm-resource.tsx Outdated
</VMDetailsItem>

<VMDetailsItem title="VM Instance" idValue={prefixedID(id, 'vmi')} isNotAvail={!getName(vmi)}>
{getName(vmi) && (
Copy link
Contributor

@glekner glekner Jan 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is redundant

Copy link
Member Author

@yaacov yaacov Jan 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks, fixed

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 1, 2020
@glekner
Copy link
Contributor

glekner commented Jan 2, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 2, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 2, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: glekner, yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@yaacov
Copy link
Member Author

yaacov commented Jan 2, 2020

/hold

until e2e tests get well

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 2, 2020
@spadgett
Copy link
Member

spadgett commented Jan 2, 2020

/hold cancel
/retest
#3847 has fixed the e2e tests

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 2, 2020
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 3, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 34cade1 into openshift:master Jan 3, 2020
@spadgett spadgett added this to the v4.4 milestone Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhrazdil rhrazdil Awaiting requested review from rhrazdil

@atiratree atiratree Awaiting requested review from atiratree

1 more reviewer

@glekner glekner glekner requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@glekner glekner

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/kubevirt Related to kubevirt-plugin lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v4.4

Development

Successfully merging this pull request may close these issues.

6 participants

@yaacov @glekner @openshift-ci-robot @openshift-bot @spadgett @openshift-merge-robot