Add support for listing and installation of Helm Charts from Dev Catalog #3850

rohitkrai03 · 2020-01-02T17:52:54Z

Related JIRA Story - https://issues.redhat.com/browse/ODC-2522
Related JIRA Story - https://issues.redhat.com/browse/ODC-2523

Depends on #3826

This PR -

Adds support for listing Helm Charts into Developer Catalog.
Adds a filter for Helm Charts.
Uses keywords from Helm Chart metadat to categorize the Helm Charts.
Uses sample Helm Charts repo endpoint to fetch the Helm Charts - https://raw.githubusercontent.com/IBM/charts/master/repo/community/index.yaml.

This PR also -

Adds a basic form for Helm Installation.
Uses Helm Install API added by PR - Adding helm service endpoints to console #3826.
After successfull install user is redirected to topology.

Note - The sample endpoint needs to be replaced once the final API for listing Helm Charts will be integrated into console backend.

Screencast -

Helm List

Helm Install

@openshift/team-devconsole-ux

andrewballantyne · 2020-01-02T19:36:07Z

/kind feature

christianvogt · 2020-01-07T16:35:59Z

frontend/packages/dev-console/src/components/helm/HelmInstallPage.tsx

Shouldn't the param values be encoded? At least chartURL since its value comes from an external source.

christianvogt · 2020-01-07T16:38:11Z

frontend/packages/dev-console/src/components/helm/HelmInstallPage.tsx

Would be good to give types to these even if our older forms don't do this yet.

christianvogt · 2020-01-07T16:38:31Z

frontend/packages/dev-console/src/components/helm/HelmInstallPage.tsx

Missing type to share with handleSubmit values.

christianvogt · 2020-01-07T16:40:55Z

frontend/public/components/catalog/catalog-page.tsx

uri encode params? At least the chartURL since value comes from external source.

christianvogt · 2020-01-11T15:03:34Z

frontend/packages/dev-console/src/components/helm/HelmInstallForm.tsx

Wrong test-id

christianvogt · 2020-01-11T15:11:46Z

frontend/public/components/catalog/catalog-page.tsx

Hmm... we should visit the array-type rule to see if we can enforce consistency for using string[] or Array<string>. Nothing to change here, I'm just making a note because we do both everywhere.

rohitkrai03 · 2020-01-13T20:17:28Z

/test e2e-gcp-console

christianvogt · 2020-01-13T22:08:41Z

Looks good.
Is this still a WIP?

rohitkrai03 · 2020-01-14T19:08:01Z

@christianvogt Work wise this is not WIP. Just waiting on the backend API PR - #3826 to get in. Should I remove the WIP tag?

andrewballantyne · 2020-01-14T19:11:14Z

@christianvogt Work wise this is not WIP. Just waiting on the backend API PR - #3826 to get in. Should I remove the WIP tag?

@rohitkrai03 Maybe use the /hold tag, since as the author you are no longer "working on it"? Semantics really, but I think WIP looks like you have a half completed implementation and are still working on it.

My two cents.

rohitkrai03 · 2020-01-14T19:16:15Z

Adding hold as it depends on #3826
/hold

benjaminapetersen · 2020-01-15T18:03:49Z

/assign @christianvogt
I think.

divyanshiGupta · 2020-01-20T14:18:40Z

/lgtm

christianvogt · 2020-01-21T02:12:14Z

/approve

debsmita1 · 2020-01-21T05:48:24Z

/retest

andrewballantyne · 2020-01-21T16:06:03Z

@rohitkrai03 this is fully reviewed and CI tests pass... is this something we can merge? (ie drop the /hold?)

rohitkrai03 · 2020-01-21T16:21:35Z

/hold cancel

spadgett · 2020-01-21T23:18:29Z

/hold
the merge queue is blocked

spadgett · 2020-01-22T01:32:16Z

/hold cancel
/retest

divyanshiGupta · 2020-01-22T10:24:35Z

/lgtm

openshift-ci-robot · 2020-01-22T10:26:01Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, divyanshiGupta, rohitkrai03

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [christianvogt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2020-01-22T10:34:07Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-22T10:45:43Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-22T11:11:38Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-22T13:08:55Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 2, 2020

openshift-ci-robot requested review from jhadvig and spadgett January 2, 2020 17:53

openshift-ci-robot added the component/core Related to console core functionality label Jan 2, 2020

rohitkrai03 force-pushed the list-helm-charts branch 2 times, most recently from cd9b720 to d8be1d5 Compare January 2, 2020 18:25

openshift-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 2, 2020

rohitkrai03 force-pushed the list-helm-charts branch from d8be1d5 to 6aef58d Compare January 6, 2020 16:43

openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. component/dev-console Related to dev-console and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 6, 2020

christianvogt reviewed Jan 7, 2020

View reviewed changes

rohitkrai03 mentioned this pull request Jan 9, 2020

feat(dev-catalog): Rename & Reorder existing filters in Dev Catalog #3890

Merged

rohitkrai03 force-pushed the list-helm-charts branch 2 times, most recently from 3128cb4 to 176ca10 Compare January 11, 2020 14:32

christianvogt reviewed Jan 11, 2020

View reviewed changes

rohitkrai03 force-pushed the list-helm-charts branch from 176ca10 to 2e8099a Compare January 12, 2020 11:03

rohitkrai03 changed the title ~~[WIP] Add support for listing Helm Charts in Dev Catalog~~ Add support for listing and installation of Helm Charts from Dev Catalog Jan 14, 2020

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 14, 2020

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 14, 2020

sbose78 mentioned this pull request Jan 15, 2020

Added helm chart repo proxy to the console backend #3928

Merged

openshift-ci-robot assigned christianvogt Jan 15, 2020

openshift-ci-robot assigned divyanshiGupta Jan 20, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2020

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 21, 2020

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 21, 2020

openshift-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jan 22, 2020

rohitkrai03 added 3 commits January 22, 2020 15:14

Add support for listing Helm Charts in Dev Catalog

7148dd1

Add support for Helm Install with release form and backend API

695df22

Update backend API endpoints and add helm logo

300bafd

rohitkrai03 force-pushed the list-helm-charts branch from 043927c to 300bafd Compare January 22, 2020 09:49

openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 22, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2020

openshift-merge-robot merged commit b7a0c27 into openshift:master Jan 22, 2020

spadgett added this to the v4.4 milestone Jan 27, 2020

rohitkrai03 deleted the list-helm-charts branch March 30, 2020 15:18

Add support for listing and installation of Helm Charts from Dev Catalog #3850

Add support for listing and installation of Helm Charts from Dev Catalog #3850

Uh oh!

Conversation

rohitkrai03 commented Jan 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Depends on #3826

This PR -

This PR also -

Screencast -

Helm List

Helm Install

Uh oh!

andrewballantyne commented Jan 2, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rohitkrai03 commented Jan 13, 2020

Uh oh!

christianvogt commented Jan 13, 2020

Uh oh!

rohitkrai03 commented Jan 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

andrewballantyne commented Jan 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rohitkrai03 commented Jan 14, 2020

Uh oh!

benjaminapetersen commented Jan 15, 2020

Uh oh!

divyanshiGupta commented Jan 20, 2020

Uh oh!

christianvogt commented Jan 21, 2020

Uh oh!

debsmita1 commented Jan 21, 2020

Uh oh!

andrewballantyne commented Jan 21, 2020

Uh oh!

rohitkrai03 commented Jan 21, 2020

Uh oh!

spadgett commented Jan 21, 2020

Uh oh!

spadgett commented Jan 22, 2020

Uh oh!

divyanshiGupta commented Jan 22, 2020

Uh oh!

openshift-ci-robot commented Jan 22, 2020

Uh oh!

openshift-bot commented Jan 22, 2020

Uh oh!

openshift-bot commented Jan 22, 2020

Uh oh!

openshift-bot commented Jan 22, 2020

Uh oh!

openshift-bot commented Jan 22, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

rohitkrai03 commented Jan 2, 2020 •

edited

Loading

rohitkrai03 commented Jan 14, 2020 •

edited

Loading

andrewballantyne commented Jan 14, 2020 •

edited

Loading