Container Security Operator UI Improvements #3874

alecmerdler · 2020-01-06T21:23:17Z

Description

Improves on the OpenShift integration with Quay via the Container Security Operator (CSO) console extension.

Changes

List view for ImageManifestVuln
Detail view for ImageManifestVuln
Nav item for ImageManifestVuln under Administration
Kebab action for Pods to view associated ImageManifestVulns (if any)

Screenshots

ImageManifestVuln list view:

ImageManifestVuln detail view:

ImageManifestVuln detail view (continued):

ImageManifestVuln detail view (affected pods):

Kebab action on Pods list view:

Future Work

Image Security tab on Pod detail view (requires HorizontalNavTab Extension #3917)
End-to-end tests using Protractor

Addresses https://issues.redhat.com/browse/PROJQUAY-119

itsptk · 2020-01-07T13:03:00Z

FYI @beanh66 @alimobrem

alecmerdler · 2020-01-17T20:41:58Z

frontend/public/components/pod.tsx

Looks like Pods got left out of the kebab extensions.

frontend/packages/container-security/src/components/image-manifest-vuln.scss

frontend/packages/container-security/src/kebab-actions.ts

spadgett · 2020-01-17T20:44:16Z

frontend/packages/container-security/src/kebab-actions.ts

Suggested change

const ready = _.get(obj.status, 'containerStatuses', []).length > 0;

const ready = (obj.status?.containerStatuses || []).length > 0;

I forgot that we can use optional chaining now!

@alecmerdler You'll need to rebase the PR for the eslint / prettier updates to use optional chaining, #3747

spadgett · 2020-01-17T20:45:48Z

frontend/packages/container-security/src/kebab-actions.ts

Should this be list?

spadgett · 2020-01-17T20:47:51Z

frontend/packages/container-security/src/plugin.ts

chunk name doesn't match the others

spadgett

/approve
/lgtm

thanks @alecmerdler 👍

spadgett

/approve
/lgtm

openshift-bot · 2020-01-21T16:27:32Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-21T19:19:19Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-21T23:08:13Z

/retest

Please review the full test history for this PR and help us cut down flakes.

spadgett · 2020-01-21T23:18:06Z

/hold
the merge queue is blocked

spadgett · 2020-01-22T01:31:58Z

/hold cancel
/retest

openshift-bot · 2020-01-22T01:42:47Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-22T01:56:45Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-22T02:42:25Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-22T06:12:34Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-22T06:25:35Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-22T13:22:24Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-22T13:34:43Z

/retest

Please review the full test history for this PR and help us cut down flakes.

spadgett · 2020-01-22T13:42:03Z

/hold

ERROR in /go/src/github.com/openshift/console/frontend/packages/container-security/src/plugin.ts
(127,9): Types of property 'componentProps' are incompatible.
  Type '{ name: string; resource: string; required: string; testID: string; }' is not assignable to type 'Pick<NavLinkProps, "startsWith" | "name" | "testID"> & Pick<ResourceNSLinkProps, "resource" | "model">'.
    Object literal may only specify known properties, and 'required' does not exist in type 'Pick<NavLinkProps, "startsWith" | "name" | "testID"> & Pick<ResourceNSLinkProps, "resource" | "model">'.

spadgett · 2020-01-22T19:51:06Z

/hold cancel

spadgett · 2020-01-22T19:52:17Z

/lgtm

openshift-ci-robot · 2020-01-22T19:53:06Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alecmerdler, spadgett

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [spadgett]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

alecmerdler changed the title ~~Container Security Operator UI Improvements~~ [WIP] Container Security Operator UI Improvements Jan 6, 2020

openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 6, 2020

openshift-ci-robot requested review from rhamilto and spadgett January 6, 2020 21:23

openshift-ci-robot added the component/core Related to console core functionality label Jan 6, 2020

alecmerdler force-pushed the bugzilla-1768496 branch from fee5879 to a12e505 Compare January 8, 2020 03:11

openshift-ci-robot added the component/sdk Related to console-plugin-sdk label Jan 8, 2020

alecmerdler force-pushed the bugzilla-1768496 branch 3 times, most recently from dd6f0bd to bf6f25c Compare January 10, 2020 00:37

alecmerdler mentioned this pull request Jan 10, 2020

HorizontalNavTab Extension #3917

Merged

alecmerdler force-pushed the bugzilla-1768496 branch from bf6f25c to b147789 Compare January 10, 2020 23:13

alecmerdler changed the title ~~[WIP] Container Security Operator UI Improvements~~ Container Security Operator UI Improvements Jan 10, 2020

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 10, 2020

alecmerdler force-pushed the bugzilla-1768496 branch 5 times, most recently from 6042694 to d7d0f53 Compare January 14, 2020 23:38

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 14, 2020

alecmerdler force-pushed the bugzilla-1768496 branch from d7d0f53 to 6593688 Compare January 14, 2020 23:48

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 14, 2020

alecmerdler force-pushed the bugzilla-1768496 branch 2 times, most recently from 92b0103 to 70aa25e Compare January 16, 2020 07:35

alecmerdler commented Jan 17, 2020

View reviewed changes

frontend/public/components/pod.tsx Outdated

Copy link

Contributor Author

alecmerdler Jan 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like Pods got left out of the kebab extensions.

spadgett reviewed Jan 17, 2020

View reviewed changes

alecmerdler force-pushed the bugzilla-1768496 branch from 70aa25e to 1c5686b Compare January 17, 2020 21:20

spadgett approved these changes Jan 17, 2020

View reviewed changes

spadgett approved these changes Jan 21, 2020

View reviewed changes

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2020

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 21, 2020

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 22, 2020

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 22, 2020

add ImageManifestVuln list/detail views

39b5d27

alecmerdler force-pushed the bugzilla-1768496 branch from 226d3ee to 39b5d27 Compare January 22, 2020 19:50

openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2020

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 22, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2020

openshift-merge-robot merged commit 8b632c8 into openshift:master Jan 22, 2020

alecmerdler deleted the bugzilla-1768496 branch January 23, 2020 02:06

spadgett added this to the v4.4 milestone Jan 27, 2020

itsptk mentioned this pull request Jan 29, 2020

Quay Image Vulnerabilities list and details & cluster dashboard vulnerability status improvements openshift/openshift-origin-design#320

Merged

	const ready = _.get(obj.status, 'containerStatuses', []).length > 0;
	const ready = (obj.status?.containerStatuses \|\| []).length > 0;

Container Security Operator UI Improvements #3874

Container Security Operator UI Improvements #3874

Uh oh!

Conversation

alecmerdler commented Jan 6, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changes

Screenshots

Future Work

Uh oh!

itsptk commented Jan 7, 2020

Uh oh!

alecmerdler Jan 17, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

spadgett Jan 17, 2020

Choose a reason for hiding this comment

Uh oh!

alecmerdler Jan 17, 2020

Choose a reason for hiding this comment

Uh oh!

spadgett Jan 17, 2020

Choose a reason for hiding this comment

Uh oh!

spadgett Jan 17, 2020

Choose a reason for hiding this comment

Uh oh!

spadgett Jan 17, 2020

Choose a reason for hiding this comment

Uh oh!

spadgett left a comment

Choose a reason for hiding this comment

Uh oh!

spadgett left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-bot commented Jan 21, 2020

Uh oh!

openshift-bot commented Jan 21, 2020

Uh oh!

openshift-bot commented Jan 21, 2020

Uh oh!

spadgett commented Jan 21, 2020

Uh oh!

spadgett commented Jan 22, 2020

Uh oh!

openshift-bot commented Jan 22, 2020

Uh oh!

openshift-bot commented Jan 22, 2020

Uh oh!

openshift-bot commented Jan 22, 2020

Uh oh!

openshift-bot commented Jan 22, 2020

Uh oh!

openshift-bot commented Jan 22, 2020

Uh oh!

openshift-bot commented Jan 22, 2020

Uh oh!

openshift-bot commented Jan 22, 2020

Uh oh!

spadgett commented Jan 22, 2020

Uh oh!

spadgett commented Jan 22, 2020

Uh oh!

spadgett commented Jan 22, 2020

Uh oh!

openshift-ci-robot commented Jan 22, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

alecmerdler commented Jan 6, 2020 •

edited

Loading