Initial boot order tests #3904
Initial boot order tests #3904
Conversation
openshift-ci-robot
added
the
size/L
openshift-ci-robot
added
approved
There was a problem hiding this comment.
@yaacov @suomiy I'm reeeeally not sure about this :D I'm not able to get the DnD working with protractor, apparently it doesn't support HTML5 Drag and drop....
I took this from https://github.com/html-dnd/html-dnd
Opinions?
There was a problem hiding this comment.
can't we rather use html-dnd and add it as a dependency?
There was a problem hiding this comment.
Yeah, how can I add it as a dependency?
There was a problem hiding this comment.
cd frontend
yarn add --dev html-dnd -W
There was a problem hiding this comment.
@yaacov These selectors (this and the one below) are not optimal, maybe you could guide me to the code of these element so that we could add some test-data-id attribute?
There was a problem hiding this comment.
rhrazdil
force-pushed
the
rhrazdil-boot-order-tests
branch
from
1b201d1 to
1a6fea9
Compare
|
/test e2e-gcp-console |
rhrazdil
force-pushed
the
rhrazdil-boot-order-tests
branch
from
1a6fea9 to
7f50c93
Compare
There was a problem hiding this comment.
can't we rather use html-dnd and add it as a dependency?
There was a problem hiding this comment.
can we make a function for the code bellow till the end of this function to avoid duplication of code?
There was a problem hiding this comment.
how many disks do we have here? IMO we should have at least 3 bootable + maybe few non bootable to start with
There was a problem hiding this comment.
Added additional non-bootable disk in beforeAll block
There was a problem hiding this comment.
can we check for the names as well?
There was a problem hiding this comment.
can we check that the options contain all non bootable devices?
rhrazdil
force-pushed
the
rhrazdil-boot-order-tests
branch
from
7f50c93 to
e64c93a
Compare
There was a problem hiding this comment.
@suomiy Oh dear, I missed you have approved this change :-O, wanted to split this PR into two parts to deal with the drag and drop later. I have reverted the change to the previous state, would you please re-lgtm?
|
/lgtm |
|
/retest |
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
/retest |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/retest Please review the full test history for this PR and help us cut down flakes. |
6 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
27 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
7 participants
Adding integration-tests for boot order dialog based on @yaacov 's PR.