-
Notifications
You must be signed in to change notification settings - Fork 670
Remove pod link from vm overview #3924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove pod link from vm overview #3924
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: yaacov The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@matthewcarleton @yfrimanm @glekner @davidvossel @suomiy @rhrazdil please review |
|
@irosenzw please review ( I typo'ed davidvossel by mistake in previous comment, sorry david ... ) |
|
LGTM |
|
IMO it is still useful to have the Pod reference accessible (for example for the logs) Can't we rather move it to VMI detail than just discarding it? |
Yes, AFAIK it's in @yfrimanm 's design 👍 EDIT: found it :-) |
|
@yaacov I wonder if it's confusing to have "Owner" here for VMs if we will never have an owner (unless we can surface VMIRS there?) |
@matthewcarleton this PR did not add the 'Owner' ( it was already their when I got here 😄 ) It's a k8s thing, like name and namespace, IMHO it's a design decision the will affect all resources that are not expected to have an owner, do we show the owner field or not, currently we show the owner by default on all resources even if they are not expected to have an owner, for example |
|
closing, this will be taken care of as part of #3949. |
On Jan 9 we decided that after exposing the VMI link we do not need the pod link.
This PR remove the pod link from the VM overview page.
Design:
openshift/openshift-origin-design#310
Screenshot

after:
before:
