Skip to content

Conversation

@yaacov
Copy link
Member

@yaacov yaacov commented Jan 13, 2020

On Jan 9 we decided that after exposing the VMI link we do not need the pod link.

This PR remove the pod link from the VM overview page.

Design:
openshift/openshift-origin-design#310

Screenshot
after:
example · Details · OKD

before:
example · Details · Red Hat OpenShift Container Platform

@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. component/kubevirt Related to kubevirt-plugin labels Jan 13, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yaacov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 13, 2020
@yaacov
Copy link
Member Author

yaacov commented Jan 13, 2020

@yaacov
Copy link
Member Author

yaacov commented Jan 13, 2020

@irosenzw please review ( I typo'ed davidvossel by mistake in previous comment, sorry david ... )

@yfrimanm
Copy link

LGTM

@atiratree
Copy link
Member

IMO it is still useful to have the Pod reference accessible (for example for the logs)

Can't we rather move it to VMI detail than just discarding it?

@yaacov
Copy link
Member Author

yaacov commented Jan 13, 2020

Can't we rather move it to VMI detail than just discarding it?

Yes, AFAIK it's in @yfrimanm 's design 👍

EDIT: found it :-)
https://github.com/openshift/openshift-origin-design/blob/db9fc80423a1befd3e0ee6bcd4dc2647fdba44d8/web-console/knikubevirt/VMIs/VMIs.md#vmis-details-view

@matthewcarleton
Copy link
Contributor

@yaacov I wonder if it's confusing to have "Owner" here for VMs if we will never have an owner (unless we can surface VMIRS there?)

@yaacov
Copy link
Member Author

yaacov commented Jan 13, 2020

@yaacov I wonder if it's confusing to have "Owner" here for VMs if we will never have an owner (unless we can surface VMIRS there?)

@matthewcarleton this PR did not add the 'Owner' ( it was already their when I got here 😄 )

It's a k8s thing, like name and namespace, IMHO it's a design decision the will affect all resources that are not expected to have an owner, do we show the owner field or not, currently we show the owner by default on all resources even if they are not expected to have an owner, for example namespaces details page have an owner .

@yaacov
Copy link
Member Author

yaacov commented Jan 15, 2020

closing, this will be taken care of as part of #3949.

@yaacov yaacov closed this Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/kubevirt Related to kubevirt-plugin size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants