Skip to content

Add clickable action to monitoring dashboard graph #3954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jan 22, 2020
Merged

Add clickable action to monitoring dashboard graph #3954

openshift-merge-robot merged 1 commit into from
Jan 22, 2020

Conversation

@vikram-raj
Copy link
Member

@vikram-raj vikram-raj commented Jan 14, 2020 •
edited
Loading

Story - https://issues.redhat.com/browse/ODC-2588

Peek 2020-01-14 19-05

Review this commit - ff608ae

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 14, 2020
@openshift-ci-robot openshift-ci-robot added component/core Related to console core functionality component/dev-console Related to dev-console component/monitoring Related to monitoring labels Jan 14, 2020
@vikram-raj vikram-raj changed the title Add clickable action to monitoring dashboard graph [WIP]Add clickable action to monitoring dashboard graph Jan 14, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 14, 2020
@andrewballantyne
Copy link
Contributor

andrewballantyne commented Jan 15, 2020

/kind feature

@openshift-ci-robot openshift-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 15, 2020
invincibleJai
invincibleJai reviewed Jan 16, 2020
View reviewed changes
frontend/public/components/graphs/prometheus-graph.tsx Outdated
Copy link
Member

@invincibleJai invincibleJai Jan 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we have namespace as optional here

frontend/packages/dev-console/src/components/monitoring/metrics/MonitoringMetrics.tsx Outdated
Copy link
Member

@invincibleJai invincibleJai Jan 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we extract it above and just have query0 as dependency to useEffect instead of params

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 17, 2020
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 17, 2020
@invincibleJai invincibleJai mentioned this pull request Jan 20, 2020
Merged
@vikram-raj vikram-raj force-pushed the odc-2588 branch 3 times, most recently from 5b72d57 to 5f37b1b Compare January 21, 2020 18:27
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 21, 2020
invincibleJai
invincibleJai reviewed Jan 21, 2020
View reviewed changes
frontend/packages/dev-console/src/components/monitoring/MonitoringPage.tsx Outdated
Copy link
Member

@invincibleJai invincibleJai Jan 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: typo ConnectedMonitoringMetrics

@vikram-raj vikram-raj force-pushed the odc-2588 branch 2 times, most recently from f730609 to 1315ef9 Compare January 21, 2020 18:44
@vikram-raj vikram-raj changed the title [WIP]Add clickable action to monitoring dashboard graph Add clickable action to monitoring dashboard graph Jan 21, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 21, 2020
@christianvogt
Copy link
Contributor

christianvogt commented Jan 21, 2020

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2020
@invincibleJai
Copy link
Member

invincibleJai commented Jan 22, 2020

/lgtm

verified locally works as expected

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2020
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 22, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, invincibleJai, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

openshift-bot commented Jan 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 6d9e06a into openshift:master Jan 22, 2020
@spadgett spadgett added this to the v4.4 milestone Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhi-kn abhi-kn Awaiting requested review from abhi-kn

@kyoto kyoto Awaiting requested review from kyoto

@invincibleJai invincibleJai Awaiting requested review from invincibleJai

Assignees

@invincibleJai invincibleJai

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality component/dev-console Related to dev-console component/monitoring Related to monitoring kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

v4.4

Development

Successfully merging this pull request may close these issues.

8 participants

@vikram-raj @andrewballantyne @christianvogt @invincibleJai @openshift-ci-robot @openshift-bot @spadgett @openshift-merge-robot