Bug 1796551: Create Snapshot for PVC for OCS #3976

a2batic · 2020-01-15T19:41:59Z

spadgett

I haven't reviewed this closely, but the handling of API group and kind are wrong

spadgett · 2020-01-15T21:31:51Z

frontend/public/components/pvc-snapshot.tsx

+};
+SnapshotTableHeader.displayName = 'SnapshotTableHeader';
+
+const kind = 'VolumeSnapshot';


kind is wrong here. It should be referenceForModel(VolumeSnapshotModel)

spadgett · 2020-01-15T21:35:44Z

frontend/public/components/pvc-snapshot.tsx

+        <ListPage
+            {...props}
+            canCreate={true}
+            kind="VolumeSnapshot"


Needs refernceForModel(VolumeSnapshotModel)

Or better

Suggested change

kind="VolumeSnapshot"

kind={kind}

and call referenceForModel when defining kind

spadgett · 2020-01-15T21:36:01Z

frontend/public/models/index.ts

  labelPlural: 'Persistent Volume Claims',
 };

+export const VolumeSnapshotModel: K8sKind = {


Needs an API group, correct?

Contribute this model from your plugin rather than here

spadgett · 2020-01-15T21:36:37Z

frontend/public/components/pvc-snapshot.tsx

+};
+SnapshotTableHeader.displayName = 'SnapshotTableHeader';
+
+const kind = 'VolumeSnapshot';


Suggested change

const kind = 'VolumeSnapshot';

const kind = referenceForModel(VolumeSnapshotModel);

spadgett · 2020-01-15T21:37:40Z

frontend/public/components/pvc-snapshot.tsx

+    />
+);
+
+export const SnapshotListPage = (props) => {


Please use VolumeSnapshot in the name throughout

spadgett · 2020-01-15T21:38:14Z

frontend/public/components/resource-pages.ts

    ),
  )
+  .set(referenceForModel(VolumeSnapshotModel), () =>
+    import('./pvc-snapshot' /* webpackChunkName: "snapshot" */).then(


Suggested change

import('./pvc-snapshot' /* webpackChunkName: "snapshot" */).then(

import('./volume-snapshot' /* webpackChunkName: "volume-snapshot" */).then(

and make sure the folder name matches

openshift-bot · 2020-01-29T13:29:00Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-29T13:41:22Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-29T15:38:12Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-29T17:35:04Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-29T19:33:27Z

/retest

Please review the full test history for this PR and help us cut down flakes.

bipuladh · 2020-01-30T07:12:22Z

/retest

Added new extension point for Additonal Page and linked with PVC Signed-off-by: Kanika Murarka<kmurarka@redhat.com> Signed-off-by: Bipul Adhikari<badhikar@redhat.com>

vojtechszocs · 2020-01-30T14:22:39Z

/lgtm

openshift-ci-robot · 2020-01-30T14:26:01Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a2batic, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~frontend/OWNERS~~ [vojtechszocs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

a2batic · 2020-01-30T17:05:17Z

/retitle Bug 1796551: Create Snapshot for PVC for OCS

openshift-ci-robot · 2020-01-30T17:05:20Z

@a2batic: This pull request references Bugzilla bug 1796551, which is invalid:

expected the bug to target the "4.4.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1796551: Create Snapshot for PVC for OCS

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

a2batic · 2020-01-30T17:06:20Z

/bugzilla refresh

openshift-ci-robot · 2020-01-30T17:06:28Z

@a2batic: This pull request references Bugzilla bug 1796551, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-01-30T17:42:06Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-30T18:36:53Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-30T22:13:30Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-01-30T22:52:16Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-01-31T00:27:22Z

@a2batic: All pull requests linked via external trackers have merged. Bugzilla bug 1796551 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1796551: Create Snapshot for PVC for OCS

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 15, 2020

a2batic changed the title ~~[WIP] Feature: Snapshot for PVC~~ [WIP] Feature: Snapshot for PVC for OCS Jan 15, 2020

openshift-ci-robot added the component/core Related to console core functionality label Jan 15, 2020

openshift-ci-robot requested review from kyoto and sg00dwin January 15, 2020 19:44

spadgett requested changes Jan 15, 2020

View reviewed changes

a2batic force-pushed the snapshot branch from 8665e79 to be1158a Compare January 16, 2020 07:26

a2batic force-pushed the snapshot branch from be1158a to bec529d Compare January 16, 2020 08:06

openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 16, 2020

a2batic force-pushed the snapshot branch from bec529d to 23d228a Compare January 16, 2020 09:42

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 29, 2020

a2batic force-pushed the snapshot branch from c2b687f to e5753b7 Compare January 30, 2020 06:48

openshift-ci-robot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jan 30, 2020

Feature: Snapshot for a PVC

25bf7a7

Added new extension point for Additonal Page and linked with PVC Signed-off-by: Kanika Murarka<kmurarka@redhat.com> Signed-off-by: Bipul Adhikari<badhikar@redhat.com>

bipuladh force-pushed the snapshot branch from e5753b7 to 25bf7a7 Compare January 30, 2020 07:36

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2020

openshift-ci-robot changed the title ~~Feature: Snapshot for PVC for OCS~~ Bug 1796551: Create Snapshot for PVC for OCS Jan 30, 2020

openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 30, 2020

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 30, 2020

openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jan 30, 2020

openshift-merge-robot merged commit e139e8d into openshift:master Jan 31, 2020

spadgett added this to the v4.4 milestone Feb 4, 2020

	const kind = 'VolumeSnapshot';
	const kind = referenceForModel(VolumeSnapshotModel);

	import('./pvc-snapshot' /* webpackChunkName: "snapshot" */).then(
	import('./volume-snapshot' /* webpackChunkName: "volume-snapshot" */).then(

Bug 1796551: Create Snapshot for PVC for OCS #3976

Bug 1796551: Create Snapshot for PVC for OCS #3976

Uh oh!

Conversation

a2batic commented Jan 15, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

spadgett left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

openshift-bot commented Jan 29, 2020

Uh oh!

openshift-bot commented Jan 29, 2020

Uh oh!

openshift-bot commented Jan 29, 2020

Uh oh!

openshift-bot commented Jan 29, 2020

Uh oh!

openshift-bot commented Jan 29, 2020

Uh oh!

bipuladh commented Jan 30, 2020

Uh oh!

vojtechszocs commented Jan 30, 2020

Uh oh!

openshift-ci-robot commented Jan 30, 2020

Uh oh!

a2batic commented Jan 30, 2020

Uh oh!

openshift-ci-robot commented Jan 30, 2020

Uh oh!

a2batic commented Jan 30, 2020

Uh oh!

openshift-ci-robot commented Jan 30, 2020

Uh oh!

openshift-bot commented Jan 30, 2020

Uh oh!

openshift-bot commented Jan 30, 2020

Uh oh!

openshift-bot commented Jan 30, 2020

Uh oh!

openshift-bot commented Jan 30, 2020

Uh oh!

openshift-ci-robot commented Jan 31, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

a2batic commented Jan 15, 2020 •

edited

Loading