Fix error creating connectors in Topology #3986
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
size/XS
jeff-phillips-18
force-pushed
the
connector-error
branch
from
fa40448 to
435e47e
Compare
Contributor
|
/kind bug |
openshift-ci-robot
added
the
kind/bug
andrewballantyne
approved these changes
Jan 16, 2020
Contributor
andrewballantyne
left a comment
andrewballantyne
left a comment
There was a problem hiding this comment.
That looks like it will solve the issue. The base k8s resources return an empty string out of referenceFor and thus fail to get the model.
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewballantyne, jeff-phillips-18 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Member
Author
|
/test analyze |
Member
Author
|
Adding fix to #4003 since it is dependent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://issues.redhat.com/browse/ODC-2726
/cc @andrewballantyne