Reconcile feature flag extensions

[vojtechszocs]

This PR aligns ModelFeatureFlag and ActionFeatureFlag extensions and their usage.

By design, every instance of ^^ represents a plugin's intent to add new Console feature flag.

To validate this invariant, the corresponding extension test (features.spec.ts) is updated to check for duplicate flag declarations.

@alecmerdler @jeff-phillips-18 I've made two major changes in the OLM plugin:

1. Removing base flags from OLM Flags enum

 export enum Flags {
   OPERATOR_LIFECYCLE_MANAGER = 'OPERATOR_LIFECYCLE_MANAGER',
-  CAN_LIST_PACKAGE_MANIFEST = 'CAN_LIST_PACKAGE_MANIFEST',
-  CAN_LIST_OPERATOR_GROUP = 'CAN_LIST_OPERATOR_GROUP',
 }

since they are already declared in Console FLAGS enum.

2. Removing CAN_LIST_PACKAGE_MANIFEST flag extension

-  {
-    type: 'FeatureFlag/Model',
-    properties: {
-      model: models.PackageManifestModel,
-      flag: Flags.CAN_LIST_PACKAGE_MANIFEST,
-    },
-  },

since it basically overrides the base SSAR check in public/actions/features.ts

{
  // TODO: Move into OLM plugin
  flag: FLAGS.CAN_LIST_PACKAGE_MANIFEST,
  resourceAttributes: {
    group: 'operators.coreos.com',
    resource: 'packagemanifests',
    verb: 'list',
  },
},

@bipuladh @rawagner ExtensionRegistry is modified to support the disallowed property. Dashboard related extensions should now support both disallowed and required.

Unknown flag check in public/reducers/features.ts is updated to take plugin contributed flags into account.

cc @spadgett @christianvogt

[vojtechszocs]

@spadgett Adding SelfSubjectAccessReview feature flag extension would be the next follow-up step, which would allow us to address TODO: Move into OLM plugin comments in base ssarChecks.

[alecmerdler]

/lgtm

[spadgett]

/hold
for #3747

[spadgett]

/hold cancel

[bipuladh]

.reduce( (gatingFlags, ext) => ext.properties.required || ext.properties.disallowed ? 
    _.uniq(....)
: gatingFlags)

maybe only use reduce?

[vojtechszocs]

Sure, I can put the filter logic inside the reduce handler.

[bipuladh]

Some plugins might need to support k8sWatch which does not return a promise.

Suggested change

	detect: (dispatch: Dispatch) => Promise<any>;
	detect: (dispatch: Dispatch) => Promise<any> | void;

[vojtechszocs]

@bipuladh @cloudbehl Regarding Bipul's #3987 (comment) - I've discussed it with @rawagner, using k8sWatch with this particular extension type can lead to problems.

On a vanilla k8s cluster or a cluster without OCS capability, CRD for OCSServiceModel is missing which causes k8sWatch for OCSServiceModel CR instance to be repeatedly failing (due to missing CRD) and causing error messages over time.

Detection of various platforms (OpenShift, Baremetal, etc.) typically uses coFetchJSON or k8sGet which are basically one-time detections. For them, using the ActionFeatureFlag extension is a good fit.

However, in case of OCS "independent" flag, driven by a specific OCSServiceModel CR instance:

k8sWatch(OCSServiceModel, { ns: 'openshift-storage', name: 'ocs-storagecluster' })

I can see two solutions here:

1. One-time detection of OCS "independent" flag (not via websocket) - if we expect the specific OCSServiceModel CR instance to be always present on an OCS-enabled cluster.

2. Use ModelFeatureFlag extension to detect presence of OCSServiceModel CRD, then use a (to be implemented) new extension type whose detector function executes whenever the specified Console flags change. In other words, first detect the presence of a CRD and then, once we know the CRD exists on the cluster, open a websocket and use it to drive the actual OCS "independent" flag.

[vojtechszocs]

Rebased and addressed #3987 (comment)

[vojtechszocs]

/retest

[rawagner]

/lgtm
/retest

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alecmerdler, bipuladh, rawagner, vojtechszocs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• frontend/OWNERS [rawagner,vojtechszocs]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[spadgett]

/hold
the merge queue is blocked

[spadgett]

/hold cancel
/retest